Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1233752pxj; Wed, 19 May 2021 01:06:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTgsXK+/3R/YYURFAx1+jYk2FS4UVokxd14UYxhbDsoIUKHWG08DO6d3QraqWESoQDxr9v X-Received: by 2002:a05:6402:30a2:: with SMTP id df2mr12512168edb.176.1621411617867; Wed, 19 May 2021 01:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621411617; cv=none; d=google.com; s=arc-20160816; b=O+WT4+Vezt8VLAFWZdYkjWIzYDPtxy/lg+S2fWVchDa5B57qoMw4G8kxGu8SyFaLNq gFGGVpBKgjtMT0kNs9rwvv3iR+W9ltwNZ5kFPUGlPqR8gYMcmkDPwBpG8Lft1ycsYPva Oxvl4ljwW4DnEEar/FpfI93bwyGcTVDjbTE+ES8KVxNWO4y7KNUc4TkR2h/IqlI1FrcG lrl0poWt1p7xjdyor5Ksm2fog3l5WIn7SQopSMqCoFV8aoPZiw95HuWaOz/jEKJD5FW3 XPOXqJzSbVJ2MW11K3gelZ0Li5/ZkXjf4X93LyDP6Lew4msGxsah4qqYk7vfc8TLuY6E lnAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=WzNUoUY7AUzQjydPiHh/ZS4e3yrInAcISdLJEmYM3yc=; b=M/JvGWQFzNrq2APCZZ2Xx+l08jTuMxog6GWkG1hhmnDXM4Cp1ZRkv57/6lLJQ1xr5z 4eMO3NTnZWtUmdmydKEg39RxMvu8FM3PkSRtFDQq7nK0913oWlW0iAxtmYsbcM1Aj1u+ WDhUd26BxqsZ/H/tnC4KXVb3jyGIX0bdN1d2oLSfQFuIbrbyKFCedIHiH4xQGTGRbZwY E5pfiUFLnDHdXYEPvM088VpSR29xonBZGkXaak0lKnkOUCPVPgMver707sefTGme5Bfn pi3bDPEFxRSGht90/xKxj/8apnyV+HMTR6h8KR566y243FpOTAClyhDiAg4g8q/A9Ucw EAkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=Wh5JfGpU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si7970827ejs.216.2021.05.19.01.06.33; Wed, 19 May 2021 01:06:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=Wh5JfGpU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237072AbhEQUzk (ORCPT + 99 others); Mon, 17 May 2021 16:55:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233271AbhEQUzk (ORCPT ); Mon, 17 May 2021 16:55:40 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6612AC061573 for ; Mon, 17 May 2021 13:54:23 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id d11so7218789iod.5 for ; Mon, 17 May 2021 13:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=WzNUoUY7AUzQjydPiHh/ZS4e3yrInAcISdLJEmYM3yc=; b=Wh5JfGpUaPJojzaNAJdl3t0QkhsYdECNwc7XO4FVOOoiBQrXIcmGr2ZP/wREltRbB1 fjEXaxhFvw3FgNeJWbg0ErSkZ1xl1iAapPD0SVAtsr7JYb/yFf5Uk2eBTTBtd1frw1la Ym7pwwlLrenCybZD5B4vp0ky0zwOxWJDHqUuRc0HOjyQqLVH2/KqIskhf1FsSL+Dp8/e xYxjMOaPVELZdOjae1WMx6QQWjjpfKjeTO5K3l7dItJheVjfWhhY8naIoVnRcTHKuoHY vU1S+zxJviCcNNw3R5CIkt4m0RtXmJFEGfYG4RDLsM1HBzqv7VQhrv0iKi2dn7GZlKJi 58zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=WzNUoUY7AUzQjydPiHh/ZS4e3yrInAcISdLJEmYM3yc=; b=kRHDSwHPFR+0REauumymdXXBhxRo9mDH+Dedmtx4pR9AnE4gNPDU823IT0NeaHbThS gcEtCl0LJrEOfP77/pGCzYKAr1uiS6SV1FD5S8XU2M6V8AuwrfVdz4hzw4cb+BIT8grh svs7fF77to2ddrcZQIaMzeRfHO6W5HG7mGSOF40QUXPkf7cc1MmPVK/Hh5eiuiunJpBD YiNJ3oIEyzZGdNlUa3P6tTfyM6DzV4y6i5cgo6iYkdDF3TWXfhhUX1IcmSdHZ//8MbVb UnfUhnSSzT423dHHfML4nD56HAzeOzI7mIYD2fl1hQyK6tQvEODmPVGUDv/Ru8XY1cj6 aMxw== X-Gm-Message-State: AOAM531dMN6S7V63/Au/BM2kk0jrkMpZoQc6jY1HQTQnqvR22RbLDS7e U1uxCJe5ddc6KhDmZvmnRIMyJw== X-Received: by 2002:a05:6638:138e:: with SMTP id w14mr1906162jad.33.1621284862780; Mon, 17 May 2021 13:54:22 -0700 (PDT) Received: from localhost ([2601:602:9200:1465:17ad:f4bd:897d:c28a]) by smtp.gmail.com with ESMTPSA id v16sm9581998ilq.45.2021.05.17.13.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 13:54:22 -0700 (PDT) From: Kevin Hilman To: Martin Blumenstingl , narmstrong@baylibre.com, linux-amlogic@lists.infradead.org Cc: jbrunet@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Blumenstingl Subject: Re: [PATCH] soc: amlogic: meson-ee-pwrc: Rename "get_power" to "is_powered_off" In-Reply-To: <20210517202115.1004065-1-martin.blumenstingl@googlemail.com> References: <20210517202115.1004065-1-martin.blumenstingl@googlemail.com> Date: Mon, 17 May 2021 13:54:20 -0700 Message-ID: <7hcztpt72b.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Martin Blumenstingl writes: > The name "get_power" is used within the Meson EE power controller driver > to indicate whether a power domain is turned on or off. With the > original "get_power" naming the result was: > - true = powered off > - false = powered on > > Rename "get_power" to "is_powered_off" to make the naming consistent > with the third argument to pm_genpd_init. Also this naming is easier to > understand when reading the code without looking at the implementation > of "get_power". > > Signed-off-by: Martin Blumenstingl Reviewed-by: Kevin Hilman