Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang
To:     Jeffrey E Altman <jaltman@auristor.com>,
        "Gustavo A. R. Silva (gustavoars@kernel.org)" <gustavoars@kernel.org>,
        David Howells <dhowells@redhat.com>
Cc:     linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <20210420211615.GA51432@embeddedor>
 <45926d81-cfae-8465-84e6-af76d668c1ef@auristor.com>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Message-ID: <c143cfde-c761-a19f-deef-2dc61a8b8947@embeddedor.com>
Date:   Mon, 17 May 2021 19:33:33 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <45926d81-cfae-8465-84e6-af76d668c1ef@auristor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/21/21 18:03, Jeffrey E Altman wrote:
> On 4/20/2021 5:16 PM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>> warnings by explicitly adding multiple fallthrough pseudo-keywords
>> in places where the code is intended to fall through to the next
>> case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> Changes in v2:
>>   - Place blank line after the fallthrough markings, not before.
>>     Link: https://lore.kernel.org/linux-hardening/748935.1606147853@warthog.procyon.org.uk/
> 
> This change looks good to me.
> 
> Reviewed-by: Jeffrey Altman <jaltman@auristor.com>

Thanks, Jeffrey.

Could someone take this, please?

Thanks
--
Gustavo