Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     gregkh@linuxfoundation.org, marcocesati@gmail.com,
        fabioaiuto83@gmail.com, fmdefrancesco@gmail.com,
        eantoranz@gmail.com, hdegoede@redhat.com,
        Larry.Finger@lwfinger.net, skhan@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <20210516122927.1132356-1-desmondcheongzx@gmail.com>
 <20210516122927.1132356-8-desmondcheongzx@gmail.com>
 <20210517101302.GF1955@kadam>
From:   Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Subject: Re: [PATCH 7/7] Staging: rtl8723bs: fix block comment in
 HalBtc8723b1Ant.c
Message-ID: <197c91ac-5db2-f439-0f88-0f3da04842f6@gmail.com>
Date:   Tue, 18 May 2021 00:00:19 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210517101302.GF1955@kadam>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 17/5/21 6:13 am, Dan Carpenter wrote:
> On Sun, May 16, 2021 at 08:29:27AM -0400, Desmond Cheong Zhi Xi wrote:
>> This commit fixes the following checkpatch.pl warning:
>>
>> WARNING: Block comments use * on subsequent lines
>> +		/*
>> +		CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \
>>
>> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
>> ---
>>   drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
>> index cc7f558903ac..87156b2cd1f0 100644
>> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
>> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
>> @@ -2511,10 +2511,10 @@ void EXhalbtc8723b1ant_DisplayCoexInfo(struct btc_coexist *pBtCoexist)
>>   		CL_PRINTF(cliBuf);
>>   
>>   		/*
>> -		CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \
>> -			pCoexDm->errorCondition);
>> -		CL_PRINTF(cliBuf);
>> -		*/
>> +		 *CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)",
>> +		 *	pCoexDm->errorCondition);
>> +		 *CL_PRINTF(cliBuf);
>> +		 */
>>   	}
> 
> Always just delete dead code.  Otherwise the patchset seems good.
> 
> regards,
> dan carpenter
> 

Thanks for the feedback, Dan. I'll remove the dead code in a v2 patchset.

Best wishes,
Desmond