Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: yDmB2cse2XETlLYvxVMxeE2kZJuL/HhTvHLKa9NhXa3hA8pRZaJL8z09Fju6+CW2nJlUIxcXQ3
 ga/hk1Vl9s8wd5ZGw5zXlYXShWfnwBfqJ+vMjOa0xqERxc4Dl2f4vYiV2WieJX7/9xQKCW6NN1
 uWYweOvGqkzI8xfHfzwttdrgBh5DSipwPFQS33A8UbaF9cPirbOmzrJK6Ktaq+5dwqbN+AK6Ba
 95cuJF8/cbE59MysL2quIZHbeoB4QK5XhXYxY23F9G6D1ILkQfHSHd/2cZRj8rpZjJo4TOfA50
 AGo=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Sasha Levin <sashal@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Daniel Wagner <dwagner@suse.de>,
        Enzo Matsumiya <ematsumiya@suse.com>,
        Christoph Hellwig <hch@lst.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH AUTOSEL 5.4 2/2] nvmet: seset ns->file when open fails
Thread-Topic: [PATCH AUTOSEL 5.4 2/2] nvmet: seset ns->file when open fails
Thread-Index: AQHXS4QLY+4qNiq68Ua1UWDgR0mY1w==
Date:   Tue, 18 May 2021 04:27:32 +0000
Message-ID: <BYAPR04MB4965B34C6F9C5E833782C7C1862C9@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20210518011002.1485938-1-sashal@kernel.org>
 <20210518011002.1485938-2-sashal@kernel.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c9026b4c-fccf-4be0-32e7-08d919b5413d
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2021 04:27:32.2351
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q7dguruzbIGjas2T/ytm0kVMqU9QKxWcdmBd+kWPEVFeaVCiMJ34tXY3EzJ6exdxewDXlM5nfzNGnHgxmkARPnLWcnSPMkp2BwfQGavfegQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB6103
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sasha,=0A=
=0A=
On 5/17/21 18:20, Sasha Levin wrote:=0A=
> From: Daniel Wagner <dwagner@suse.de>=0A=
>=0A=
> [ Upstream commit 85428beac80dbcace5b146b218697c73e367dcf5 ]=0A=
>=0A=
> Reset the ns->file value to NULL also in the error case in=0A=
> nvmet_file_ns_enable().=0A=
>=0A=
> The ns->file variable points either to file object or contains the=0A=
> error code after the filp_open() call. This can lead to following=0A=
> problem:=0A=
>=0A=
> When the user first setups an invalid file backend and tries to enable=0A=
> the ns, it will fail. Then the user switches over to a bdev backend=0A=
> and enables successfully the ns. The first received I/O will crash the=0A=
> system because the IO backend is chosen based on the ns->file value:=0A=
=0A=
I think the patch subject line is being worked on since it needs to be=0A=
reset and not seset.=0A=
=0A=
Not sure how we can go about fixing that.=0A=
=0A=
=0A=