Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 1/1] MAINTAINERS: TTY LAYER: add some ./include/linux/
 header files
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210518052117.14819-1-lukas.bulwahn@gmail.com>
 <20210518052117.14819-2-lukas.bulwahn@gmail.com>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <69da627e-91c5-66f0-c0c9-75fbaaba6782@kernel.org>
Date:   Tue, 18 May 2021 07:37:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210518052117.14819-2-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18. 05. 21, 7:21, Lukas Bulwahn wrote:
> An early prototypical automated code analysis of headers and the
> existing MAINTAINERS sections identified some header files in
> ./include/linux/ to be probably included into the TTY LAYER section.
> 
> I further checked those suggestions by this analysis and identified a
> subset of files that I am rather certain to belong to the TTY LAYER.
> 
> Add these ./include/linux/ header files to TTY LAYER in MAINTAINERS.
> 
> The patterns include/linux/tty*.h and include/linux/vt_*.h currently cover:
> 
>    include/linux/tty.h
>    include/linux/tty_driver.h
>    include/linux/tty_flip.h
>    include/linux/tty_ldisc.h
> 
>    include/linux/vt_buffer.h
>    include/linux/vt_kern.h

Yes, that looks good.

Can you extend the tool to include/uapi too?

For example this is missing too:
include/uapi/linux/tty*.h

It expands to:
include/uapi/linux/tty_flags.h
include/uapi/linux/tty.h

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> applies cleanly on next-20210507
> 
>   MAINTAINERS | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8923f0064784..d056f777c1a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18563,9 +18563,13 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
>   F:	Documentation/driver-api/serial/
>   F:	drivers/tty/
>   F:	drivers/tty/serial/serial_core.c
> +F:	include/linux/selection.h
>   F:	include/linux/serial.h
>   F:	include/linux/serial_core.h
> -F:	include/linux/tty.h
> +F:	include/linux/sysrq.h
> +F:	include/linux/tty*.h
> +F:	include/linux/vt.h
> +F:	include/linux/vt_*.h
>   F:	include/uapi/linux/serial.h
>   F:	include/uapi/linux/serial_core.h
>   F:	include/uapi/linux/tty.h
> 

thanks,
-- 
js
suse labs