Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1476098pxj; Wed, 19 May 2021 06:54:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhsy3l03JBtVx/cil6mW5hfzWBA2Ii0ZX3AlNJe/jtKRGOeJ8TIjPUfZVM2bNqqdND6s3R X-Received: by 2002:a17:906:2a56:: with SMTP id k22mr12988939eje.551.1621432455279; Wed, 19 May 2021 06:54:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621432455; cv=none; d=google.com; s=arc-20160816; b=o7BSw80QVMzJH948rVPM+JY5Qp/SFoqm/NfxGh9bY5oTnoQO8mR93LfeOygJPC9TaV 5yGfMD7FnAQRj+vxBqNdUCf4PF0xIU1cbRcBlNX6mP231ZopjyIk8PCuYY6XRuEJqxj4 SMqdw2UfNya4OELeFKgOEvgdw3AKsRZRewsuOVH7yogY6lNtxgtmRJhcBrN/62mNkzRa f9bOF+ypUiCrduCMEX7Ux3Keg8AgRa2xjyBVmXxKflTr5UoSsecZfnbDrZ1qA6TbIbiG ImEIaO3A6UwlUDpb4TvlQhca8QGdl+iG7X9hWlzMALKo3mMkqis7rgJUhQSRsOY69Jmb kb7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PDyrwk3dKvoxKjer/W/nKoHZ25xkHMzcXLNqNVSjI98=; b=IbO06pOaHk1y/+3RR1Hu39n9wGw3+hmi15gDCTpLnQnRr9bnwkFfEKt0TRABWuHEI1 vty5/osoAQJFYMdafgd5h9UVxLRyPOWsoa6RJXgbMl220dfubplFUIi5J4ETHgPufAoV 1MkwI6iQah2cbp+aTrmNwFfTeEbWjNni9GGv7g2URzGHZ4aaC2GLcQ1jcfYiZNsrzPXd R4+fdeOE+XnqC1DB4FSECpK61X1KLeY07tWQYHPsICvqVNGyUu2Xib45vC4/FmxSq2Jo 4qwKFcg3vVIU4345zWKL2LLPvskEpxJrNviVujGMZhZEtw36QB01U7p3zt1bhwFreYVc YyVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VtOmdjwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx19si21106081ejb.481.2021.05.19.06.53.34; Wed, 19 May 2021 06:54:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VtOmdjwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241251AbhERGnt (ORCPT + 99 others); Tue, 18 May 2021 02:43:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241421AbhERGnr (ORCPT ); Tue, 18 May 2021 02:43:47 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A346C06175F for ; Mon, 17 May 2021 23:42:30 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id q6so4985875pjj.2 for ; Mon, 17 May 2021 23:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PDyrwk3dKvoxKjer/W/nKoHZ25xkHMzcXLNqNVSjI98=; b=VtOmdjwVV5WinnYM8kjIEP+f3T2dP4qhZew2qo2b8rOixnhhoKqE73hDfXFYiPhVG+ U6BAIa1KXGyc+Nw/pBnyzHhaT1tIpO8FD1D5RuU3Fbq8THMadmNoknnSwKB9hGOx3JSo 9OgCVPZ0ChLJsVYfXDyAbZmg8Bo+ncPHVka+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PDyrwk3dKvoxKjer/W/nKoHZ25xkHMzcXLNqNVSjI98=; b=MhDmShNBqpbUTWTbsTEyixAaHcLhbRcoYwrEfo3rBzcSkPxqEFyICQ4bHyX0BGkp2T hXkZsai/61sOfFWJt0I9kgk4J9vWTnysofKnI/Y9kKfhLfiOtJdfzvcYhHldtGQllnhe +Pcqvr+Rl9B9NoSt7XgtjmYS+QdCe6SvfJnAFUb+3Tb6Wnli9vAuG38DdQz8Q8pwfTQm HW1+UQ0Waj1wXFh1X36lyLjsJxDoOI2tJY2U+smYOvk7mZFQz2TmVwehGehw46Y4VXne IMhUa05ayXknrskc2LmON2DylSQwY6Xf4bOtSz5thFswY9HQxdnXpQTxHgPX0qCKcRKj Gc0w== X-Gm-Message-State: AOAM5300sYJK5KoKit803D+bd0oEkUg9XpuK4HDTvMM7WCrm7+hBeu8y 5GapvOghCwkg2xli/KkbcmILNg== X-Received: by 2002:a17:902:b408:b029:ec:e879:bbd8 with SMTP id x8-20020a170902b408b02900ece879bbd8mr2877299plr.65.1621320149869; Mon, 17 May 2021 23:42:29 -0700 (PDT) Received: from localhost ([2401:fa00:95:205:f284:b819:54ca:c198]) by smtp.gmail.com with UTF8SMTPSA id f21sm7240386pjt.11.2021.05.17.23.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 23:42:29 -0700 (PDT) From: Claire Chang To: Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski Cc: benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , tfiga@chromium.org, bskeggs@redhat.com, bhelgaas@google.com, chris@chris-wilson.co.uk, tientzu@chromium.org, daniel@ffwll.ch, airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jxgao@google.com, joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com Subject: [PATCH v7 00/15] Restricted DMA Date: Tue, 18 May 2021 14:42:00 +0800 Message-Id: <20210518064215.2856977-1-tientzu@chromium.org> X-Mailer: git-send-email 2.31.1.751.gd2f1c929bd-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series implements mitigations for lack of DMA access control on systems without an IOMMU, which could result in the DMA accessing the system memory at unexpected times and/or unexpected addresses, possibly leading to data leakage or corruption. For example, we plan to use the PCI-e bus for Wi-Fi and that PCI-e bus is not behind an IOMMU. As PCI-e, by design, gives the device full access to system memory, a vulnerability in the Wi-Fi firmware could easily escalate to a full system exploit (remote wifi exploits: [1a], [1b] that shows a full chain of exploits; [2], [3]). To mitigate the security concerns, we introduce restricted DMA. Restricted DMA utilizes the existing swiotlb to bounce streaming DMA in and out of a specially allocated region and does memory allocation from the same region. The feature on its own provides a basic level of protection against the DMA overwriting buffer contents at unexpected times. However, to protect against general data leakage and system memory corruption, the system needs to provide a way to restrict the DMA to a predefined memory region (this is usually done at firmware level, e.g. MPU in ATF on some ARM platforms [4]). [1a] https://googleprojectzero.blogspot.com/2017/04/over-air-exploiting-broadcoms-wi-fi_4.html [1b] https://googleprojectzero.blogspot.com/2017/04/over-air-exploiting-broadcoms-wi-fi_11.html [2] https://blade.tencent.com/en/advisories/qualpwn/ [3] https://www.bleepingcomputer.com/news/security/vulnerabilities-found-in-highly-popular-firmware-for-wifi-chips/ [4] https://github.com/ARM-software/arm-trusted-firmware/blob/master/plat/mediatek/mt8183/drivers/emi_mpu/emi_mpu.c#L132 v7: Fix debugfs, PageHighMem and comment style in rmem_swiotlb_device_init v6: Address the comments in v5 https://lore.kernel.org/patchwork/cover/1423201/ v5: Rebase on latest linux-next https://lore.kernel.org/patchwork/cover/1416899/ v4: - Fix spinlock bad magic - Use rmem->name for debugfs entry - Address the comments in v3 https://lore.kernel.org/patchwork/cover/1378113/ v3: Using only one reserved memory region for both streaming DMA and memory allocation. https://lore.kernel.org/patchwork/cover/1360992/ v2: Building on top of swiotlb. https://lore.kernel.org/patchwork/cover/1280705/ v1: Using dma_map_ops. https://lore.kernel.org/patchwork/cover/1271660/ Claire Chang (15): swiotlb: Refactor swiotlb init functions swiotlb: Refactor swiotlb_create_debugfs swiotlb: Add DMA_RESTRICTED_POOL swiotlb: Add restricted DMA pool initialization swiotlb: Add a new get_io_tlb_mem getter swiotlb: Update is_swiotlb_buffer to add a struct device argument swiotlb: Update is_swiotlb_active to add a struct device argument swiotlb: Bounce data from/to restricted DMA pool if available swiotlb: Move alloc_size to find_slots swiotlb: Refactor swiotlb_tbl_unmap_single dma-direct: Add a new wrapper __dma_direct_free_pages() swiotlb: Add restricted DMA alloc/free support. dma-direct: Allocate memory from restricted DMA pool if available dt-bindings: of: Add restricted DMA pool of: Add plumbing for restricted DMA pool .../reserved-memory/reserved-memory.txt | 27 ++ drivers/gpu/drm/i915/gem/i915_gem_internal.c | 2 +- drivers/gpu/drm/nouveau/nouveau_ttm.c | 2 +- drivers/iommu/dma-iommu.c | 12 +- drivers/of/address.c | 25 ++ drivers/of/device.c | 3 + drivers/of/of_private.h | 5 + drivers/pci/xen-pcifront.c | 2 +- drivers/xen/swiotlb-xen.c | 2 +- include/linux/device.h | 4 + include/linux/swiotlb.h | 41 ++- kernel/dma/Kconfig | 14 + kernel/dma/direct.c | 63 +++-- kernel/dma/direct.h | 9 +- kernel/dma/swiotlb.c | 242 +++++++++++++----- 15 files changed, 356 insertions(+), 97 deletions(-) -- 2.31.1.751.gd2f1c929bd-goog