Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1657116pxj; Wed, 19 May 2021 10:47:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcAtXeGzTa63bfWAixNJH110efb2pAInZ7Qg+s1MyRA9z2sqrKDs4jw3z0GASfm9gqpp7H X-Received: by 2002:a17:906:edaf:: with SMTP id sa15mr360856ejb.174.1621446429719; Wed, 19 May 2021 10:47:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621446429; cv=none; d=google.com; s=arc-20160816; b=vuIfSK4fzeTNynrnSV8wOQhN99PI1HYFNi0yzAKe6hjUrn/4fLE7gA/dtaNvw2cH3Y nCtNYO5hwUHzkF6+uzGv7WzZEfMcOGLhBiFPwf7PO2fu3YvmpetRmIc949CT9LE6Ht/M tL83h5I/AhYx9kqeLBgPL1Fi9OCFXQAdc5WcMt6IVbVItjKnSoYIxn/+6Fzw/M7PstKL 7G7iVppn0QMCeiUqP6cORj4TDDgU/Fc39DwXtjPRHW9VPFQvWDekOzESrTGswku6NFjy 56QCPd1q0nkeOAFy78WG2AvEYr5R2hle5YyyBErcvYDo4cNBwHezYO2HL/zfy0JlgXlF qlMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=r098tHE0nlpPy8H+tzPNv+PPdJXPs/G8lc3vpf4k9jM=; b=YSpSclxM8JGvXqhcgHVDNz6fEqyUMGLTjvnw5jmTZen9jj+NQRQYw4u6+NBT3NHNl4 pO/pbooT7c0iApSG1UAjDeXTis+g0iVX6JszEyEvlmIvES0zauhj4Mlt6rzkMQpaG1ix 62aRLFtcvy2pxiLvTsAM4c5qJjwzOeyb7r9IVgZB07tvvyWSxpoY6Skm2k8356JXYLxC zjG88dqntTL/iSQvDQ+lSB6uRChMM309BZ/gphMzYievy1U1/FLu6b2Cz93id9Yv+7HB /yT+xilYJbLB8rmF2PHPxUlg4Kbof2FtG4Jl2tEysZPgyyaRN2XcWRSzgN7V6jH1MaYe Gnpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g9u0046U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si647055edu.586.2021.05.19.10.46.46; Wed, 19 May 2021 10:47:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g9u0046U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243609AbhERKKx (ORCPT + 99 others); Tue, 18 May 2021 06:10:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21934 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241553AbhERKKt (ORCPT ); Tue, 18 May 2021 06:10:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621332571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r098tHE0nlpPy8H+tzPNv+PPdJXPs/G8lc3vpf4k9jM=; b=g9u0046UYJ+Z39qMOqgKV6Yva4f+VpzH08c+Gz8HpQIbDAs7C9RB93CGsr0UFSmFjmsmda xianPFbIepiYakmASE+k3unDZRIXP7JuNABiRtZ4QW1PRpxsUJs/JKucRcIXIZ0Dab28YG xPvBfI9Ym4h+UIiFYjBIFI9D4CGizn4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-lX7iFzYyPlmd8sTiiq0pqw-1; Tue, 18 May 2021 06:09:30 -0400 X-MC-Unique: lX7iFzYyPlmd8sTiiq0pqw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C8BF802B78; Tue, 18 May 2021 10:09:28 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-0.ams2.redhat.com [10.36.114.0]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 663FC5D703; Tue, 18 May 2021 10:09:27 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BBDEF180079B; Tue, 18 May 2021 12:09:25 +0200 (CEST) Date: Tue, 18 May 2021 12:09:25 +0200 From: Gerd Hoffmann To: Xie Yongji Cc: airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/virtio: Fixes a potential NULL pointer dereference on probe failure Message-ID: <20210518100925.uvddw6y5ya4ddope@sirius.home.kraxel.org> References: <20210517084913.403-1-xieyongji@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517084913.403-1-xieyongji@bytedance.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 04:49:11PM +0800, Xie Yongji wrote: > The dev->dev_private might not be allocated if virtio_gpu_pci_quirk() > or virtio_gpu_init() failed. In this case, we should avoid the cleanup > in virtio_gpu_release(). Pushed all three to drm-misc-next. thanks, Gerd