Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1659832pxj; Wed, 19 May 2021 10:50:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBF4iRht4do1/SFM5fu5pM9ZhsqM/8q/u2lK0tKt9fQQBTCQIAPjWJco3UHxzZUZKfxKEp X-Received: by 2002:a02:a80f:: with SMTP id f15mr73333jaj.101.1621446658938; Wed, 19 May 2021 10:50:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621446658; cv=none; d=google.com; s=arc-20160816; b=GFVIMId/f2QUV+4JkGzDkrmBU+ceY8MhKKD1Cykh94SJicEejEq8vs9v0W1jdAg2v+ XbwNa2gfCAhA9y0YBDtC4KLnLokWpGFJtWE+Dsf5aHONqEun5DHnj+dEnhE81Pxr6rfp 2dwuia3H5wnhlSo+mMK21GCQAN9jHpYZpTvq4cZS0NSmoLWuycFVfoQsqW0yOdolfdUn pM5o/NRILQbfLThHPXO/sCrZqgYQd3oCDxYFaIEJWRhev62mqHPD/HccmbDudCznB4wu bvS0Ll8bxbZ7i709o+7pza1Ci3DrOvBZMdtuRtRx+pP5bfvMGWkl9zjcpR4VTn7KMaIt M8rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=IWVH7+8esXWt8AGWk6357uw6q8QSvhJq0+DIE/0dDUQ=; b=DPbgmoinyIP0t0haqz8jrs8zONFUvqNm21sAM8A0QsA29FHL9KW1xi+evp1Yen+DO/ Qd38oMcctAFdiuOvB64C4/jcpdB/Z7bOqAlRIea3Y8tXi23hZGt+cpjcHBj1dxqfXQ6W 9pCsC4TWQyF1iPnwMbPFD8NFKAq4zIfkZfoWMXq7h0bEyoWB5L/qTtqUClZWbESEY+AY rao42J+8Pi3w5QkvSjKqCfrUC321jWbar+XLJZF10NAHNBQoJ6RMNr7bDcmjpmfQvA56 v72+1N5wxKPH5fGiBfav1yCO3Mm5YCeRWBBqIJbejP7Etjj//X805QLJvZcsZFYujWCX pTDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 17si281717ilj.19.2021.05.19.10.50.46; Wed, 19 May 2021 10:50:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348508AbhERKfu (ORCPT + 99 others); Tue, 18 May 2021 06:35:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:44980 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242597AbhERKft (ORCPT ); Tue, 18 May 2021 06:35:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DAE9BAF19; Tue, 18 May 2021 10:34:30 +0000 (UTC) Subject: Re: [PATCH v10 21/33] mm/filemap: Add __folio_lock_async To: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Layton References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-22-willy@infradead.org> From: Vlastimil Babka Message-ID: <7fb7b8a3-b559-88d6-b46e-d822fc689500@suse.cz> Date: Tue, 18 May 2021 12:34:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210511214735.1836149-22-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote: > There aren't any actual callers of lock_page_async(), so remove it. > Convert filemap_update_page() to call __folio_lock_async(). > > __folio_lock_async() is 21 bytes smaller than __lock_page_async(), > but the real savings come from using a folio in filemap_update_page(), > shrinking it from 514 bytes to 403 bytes, saving 111 bytes. The text > shrinks by 132 bytes in total. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton Acked-by: Vlastimil Babka