Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1660587pxj; Wed, 19 May 2021 10:52:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+GEbYBlT1fyJgvd6nANH4Lg2zHG0UCvAq0YQLN1OVD9OB/46BsHOHb7kSZTTSRJnbggu/ X-Received: by 2002:a17:907:9691:: with SMTP id hd17mr330947ejc.67.1621446726570; Wed, 19 May 2021 10:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621446726; cv=none; d=google.com; s=arc-20160816; b=P0kuqfW4eDLDqyUWFTx3pPaTGtrHP+RGQZsVsRN+4/lPEk9Z8elYPfYcnxhnxn3/9I R/569ZNxCDnt2eWVhzymuQ54NPp3cdSL/NHg/T17emonjPGNd8wMSsMDdXJMy8IyYDQK FpeN6HqcqLRs6rc1q5DQtMUYrSROTblcWyYYD75NUL2uvlXV+kQ2OZqh5p2bykzsnq2r pRGU98cievlqQ2K5HWh5Dor8OMoRAcZf7/yxhJ+nuF9EgYBgvO+mf3eJ2Sf8Z08saESJ QQdGwnp4ADffrwfX9Qc/vBWNqd4lRmzECl8eyIu1mj2mPFe+h+gva68L86T/gUxX3eQT Vg9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/pF+I9rC+2OPUFiAF4WM2VeuD5vxYIiVsmkFQfqBGOs=; b=z9EnKIUvV1tVwogTO7ADZ8j+XfdFBbzCAKGkexR9hcuFR50iDMRM2ghEQZjHZne2Sr FtqXLJ8hVqgvRLYxnbhGW2EgBLNUNBMUDhyEprmP1W6C8yCaifT6gFmnN4Z2kA2q1VqJ 5fBHe9/5W1+D+FFkVQ3qijJhWiKvgm/omm2Pf/JzbiTzzXc56zjQ77BzmIN9Xae9GCOp rhcD5ftwIfJLZu4slpKt62imFuszyf84Ul2BKYwdcNgyR1zJ5dhdcvLGM0ARsVgw2h3h 3ToIq6k8ez1I5IxlpqCHCMrG9EJEI0yhmbJ4idVOap4N4ZPlrTKrzh86gEoOFn5UNRd6 vk8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si23644426eds.16.2021.05.19.10.51.43; Wed, 19 May 2021 10:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348540AbhERKgY (ORCPT + 99 others); Tue, 18 May 2021 06:36:24 -0400 Received: from vps5.brixit.nl ([192.81.221.234]:35656 "EHLO vps5.brixit.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347935AbhERKgX (ORCPT ); Tue, 18 May 2021 06:36:23 -0400 X-Greylist: delayed 454 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 May 2021 06:36:23 EDT Received: from localhost.localdomain (unknown [77.239.252.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by vps5.brixit.nl (Postfix) with ESMTPSA id 1A3F56075F; Tue, 18 May 2021 10:27:28 +0000 (UTC) From: Alexey Minnekhanov To: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), freedreno@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-kernel@vger.kernel.org (open list) Cc: ~postmarketos/upstreaming@lists.sr.ht, Alexey Minnekhanov Subject: [PATCH] drm/msm: Init mm_list before accessing it for use_vram path Date: Tue, 18 May 2021 13:26:24 +0300 Message-Id: <20210518102624.1193955-1-alexeymin@postmarketos.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix NULL pointer dereference caused by update_inactive() trying to list_del() an uninitialized mm_list who's prev/next pointers are NULL. Signed-off-by: Alexey Minnekhanov --- drivers/gpu/drm/msm/msm_gem.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index b199942266a26..b8c873fc63a78 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1227,6 +1227,13 @@ static struct drm_gem_object *_msm_gem_new(struct drm_device *dev, to_msm_bo(obj)->vram_node = &vma->node; + /* Call chain get_pages() -> update_inactive() tries to + * access msm_obj->mm_list, but it is not initialized yet. + * To avoid NULL pointer dereference error, initialize + * mm_list to be empty. + */ + INIT_LIST_HEAD(&msm_obj->mm_list); + msm_gem_lock(obj); pages = get_pages(obj); msm_gem_unlock(obj); -- 2.26.3