Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1660628pxj; Wed, 19 May 2021 10:52:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqHRDKiIE85mzfaKEfL5G/Z08bH+SI4/F6NuG9YXVnkbIJpg44+3bjJSUa3wceA+6+6/qz X-Received: by 2002:a17:907:1b19:: with SMTP id mp25mr370223ejc.154.1621446730089; Wed, 19 May 2021 10:52:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621446730; cv=none; d=google.com; s=arc-20160816; b=VagpjgM9u5NxBkNbMtEcHqQ+8NBgkn2Hbz7CvsTh4fgvE0YBNsG/mlIvgub11eWnNo lFhD+WMhYJRpkvkAVKP3CGn3ztURqp2E9SJllJ44yBMdpm+Mimvxk0XBF03U1wiZdn/Y tXk+XaM/vgDXNLAIF7gVjN75sWvJRkU33K3uKWXd+CeIM9lKBjLLUehX976mN/FONfR6 iiyT71GYbsHWsxP1PNyQzKl9W5+PyjVO/pGKg0v+Voj4X96i4PTpAyxSzzXU0SVR6hUl i1I5CuyRiTZwyyxKi3dEBGKFuEAEKQi6f3wacDda31RCAiVdzDv4jlGWe3+WfQRHo0Zl F/lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=X4vPgjQscxAH1i4VkRjbIQfp2ooS5+SI0FP/dQVmSuw=; b=pR9+iQQPmwC/sLTKDI9TwKpwmkOBdegmlInXxMwolatnwB8wTZPXQ5W7KLZSgwnX05 Kz1UjlRQzUBfrwE5++aIiHBG4HVkcCBhD47v7NGYlhOT5XEL9SmFNTjRR52qByxMnkde HNYkkqaIw+qs2cqrfNxMavCkO/7eVtGd5MVQfbhiF+0mgltbo4FBvN4i0rkh6yRennFt VzNIEu8fhLcu6YXTrHwWHUlEjPmcy7g2UNsHKXSqIehISD83iaHAzxH/6SlmufmsRewr obcvYlBDbSK4hmGx2GsuFU9GfRuRLoQgpU9o7SCRAodnxd2SOtyphy8rjKl+PXa+sHRU 35+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t16si26523463edi.299.2021.05.19.10.51.24; Wed, 19 May 2021 10:52:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348601AbhERKm7 (ORCPT + 99 others); Tue, 18 May 2021 06:42:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:53270 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348596AbhERKm5 (ORCPT ); Tue, 18 May 2021 06:42:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C208EAD77; Tue, 18 May 2021 10:41:38 +0000 (UTC) Subject: Re: [PATCH v10 23/33] mm/filemap: Add folio_wait_locked To: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Layton References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-24-willy@infradead.org> From: Vlastimil Babka Message-ID: <59e67626-7f68-5154-1943-6cd1ab7515d6@suse.cz> Date: Tue, 18 May 2021 12:41:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210511214735.1836149-24-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote: > Also add folio_wait_locked_killable(). Turn wait_on_page_locked() > and wait_on_page_locked_killable() into wrappers. This eliminates a > call to compound_head() from each call-site, reducing text size by 200 > bytes for me. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton Acked-by: Vlastimil Babka (and it fixes filemap.c to be compilable again)