Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d4b936d1de6a1ad6d43fe9070ab5c712851eec52.camel@googlemail.com>
Subject: Re: [PATCH v2 2/2] regulator: fan53880: Convert to use .probe_new
From:   Christoph Fritz <chf.fritz@googlemail.com>
Reply-To: chf.fritz@googlemail.com
To:     Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Date:   Tue, 18 May 2021 14:00:28 +0200
In-Reply-To: <20210517105325.1227393-2-axel.lin@ingics.com>
References: <20210517105325.1227393-1-axel.lin@ingics.com>
         <20210517105325.1227393-2-axel.lin@ingics.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-05-17 at 18:53 +0800, Axel Lin wrote:
> Use the new .probe_new for fan53880.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Christoph Fritz <chf.fritz@googlemail.com>

> ---
> v2: no change
>  drivers/regulator/fan53880.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/fan53880.c b/drivers/regulator/fan53880.c
> index 1684faf82ed2..f3268b4d5066 100644
> --- a/drivers/regulator/fan53880.c
> +++ b/drivers/regulator/fan53880.c
> @@ -114,8 +114,7 @@ static const struct regmap_config fan53880_regmap = {
>  	.max_register = FAN53880_ENABLE_BOOST,
>  };
>  
> -static int fan53880_i2c_probe(struct i2c_client *i2c,
> -			     const struct i2c_device_id *id)
> +static int fan53880_i2c_probe(struct i2c_client *i2c)
>  {
>  	struct regulator_config config = { };
>  	struct regulator_dev *rdev;
> @@ -177,7 +176,7 @@ static struct i2c_driver fan53880_regulator_driver =
> {
>  		.name = "fan53880",
>  		.of_match_table	= of_match_ptr(fan53880_dt_ids),
>  	},
> -	.probe = fan53880_i2c_probe,
> +	.probe_new = fan53880_i2c_probe,
>  	.id_table = fan53880_i2c_id,
>  };
>  module_i2c_driver(fan53880_regulator_driver);