Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 May 2021 13:06:40 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Maxim Kochetkov <fido_max@inbox.ru>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        rafael@kernel.org
Subject: Re: [PATCH 1/1] regmap-irq: Introduce inverted status registers
 support
Message-ID: <20210518120640.GB4358@sirena.org.uk>
References: <20210518094441.142547-1-fido_max@inbox.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv"
Content-Disposition: inline
In-Reply-To: <20210518094441.142547-1-fido_max@inbox.ru>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--A6N2fC+uXW/VQSAv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 18, 2021 at 12:44:41PM +0300, Maxim Kochetkov wrote:

> +	if (chip->status_invert)
> +		for (i = 0; i < data->chip->num_regs; i++)
> +			data->status_buf[i] = ~data->status_buf[i];
> +

This is the only active change so this only affects readback meaning
that if both read and write are inverted this won't do what's expected,
breaking acks.  I'm guessing your device either mixes things or is clear
on read?

--A6N2fC+uXW/VQSAv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCjrc8ACgkQJNaLcl1U
h9Cg7Af9GI0Qpxu+fNYrN9Ywk0dCoF6MPMU2Ql34iejMYBLoz9IaLaCxqDmFG5KC
DVZduRncKGj7x5fBORYyR0TldNZrRN4Lv2DkaP205ufTAdv+i2vC1LMFWO0ZV6q4
huxHWqDKS1P8XGO4ITMENfGqSXCESEl41uSs7YQjE31DZH+LkzsrzqZYOVOSvPZi
mV9jqLM2mfVuM+Ngh7dxlXTNgC8wOCgUNPlWnijosHwMpGBUQZOho7QWg8x9pSSt
QShEqnlY6EhtiizvshpGqJ3gCL8yvxohG1depb5MMco/pTzjvAn48fxNIGyW2M+r
sKteP4je96+EugNNCvA5A+olnw/FBw==
=oEM3
-----END PGP SIGNATURE-----

--A6N2fC+uXW/VQSAv--