Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1673134pxj; Wed, 19 May 2021 11:08:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMauCtlwz/rqU25SArbCPINIdy0Ps2g534lVoQSzo+YFO8zkjbS3pw6sS/3eLsQ9PF89SU X-Received: by 2002:a5d:8c82:: with SMTP id g2mr769987ion.34.1621447718415; Wed, 19 May 2021 11:08:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621447718; cv=none; d=google.com; s=arc-20160816; b=XsQBfAwk3A5OwTBp/EThXU03G2TnkTakPpWNRsn7RjSZwgPxjBKDPrC3NjL+kGvh9v G/eSCli4qfRk7zCyelCz3q806RJoUaSuGLGfL+3DjSO0xpMbqhnbTOLEqsopGBHut4t/ GpZvLywEffsp9LjajA+d1LTKASrLvTTuSQRxRqN6idGw0JTKlqf/LY/0liMq/IgQ+B/S vZl1BhsJATXW7JcpTqG8Ii/Lx/RyGqzwt51eor699bKlmGOfafFVGbclvRKrRhl+wvxb IWurmqNAitPRFLZrCmuRL1VJr3B1QY9fB1QwDGeIxHh/zDtvuLqFYHgOIRD1e9lndAU1 bcSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=AHNEzygpwqRygoOae7FKciPgli51Y3fBcXRml8XxBr4=; b=Er/ycOr0XKMEHQHtI6mv6YIoddxTp+RRCvLkV5q8R27JRDQeduZxii/oHkk7/Ql0bO 0yKe4jjlFgZ700+f+/R6cGqisieskYgct6wLl8r8tH71FlMxgSQklLEubbH8bUtRDRQf vo18vqoqkvqfX6L+FYCBAYqxnc1i1mcn98ZHrwPfW8wUXtaJLvfygTlRykN9EqQHws0b c9BPRw0V20KevGz6HJyyqsDl0UzdtozdZk1caZtcTP1eEEe7l6Du6VBmgtT0o2u+0raF WYe9USjtUBPDrR5EUblZsfKFldFH5j30qlZ/fZ4+TYqSE4sQbBrUJfQNe0w5Mea/5Hc1 C+cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=hEbAO8Zm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d8si723675iob.68.2021.05.19.11.08.26; Wed, 19 May 2021 11:08:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=hEbAO8Zm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244679AbhERMrn (ORCPT + 99 others); Tue, 18 May 2021 08:47:43 -0400 Received: from first.geanix.com ([116.203.34.67]:33738 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244400AbhERMrm (ORCPT ); Tue, 18 May 2021 08:47:42 -0400 X-Greylist: delayed 476 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 May 2021 08:47:42 EDT Received: from [192.168.64.199] (unknown [185.17.218.86]) by first.geanix.com (Postfix) with ESMTPSA id 98D21464055; Tue, 18 May 2021 12:38:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1621341506; bh=N8dF9lNhoA62MtvBLfiXHYsJEDkxAjPBIVcvZZB2w84=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=hEbAO8ZmeNTFvzKOciKV7IiVmLhi32RQZ9aMpYS+O8mg4jB8lLEuTPdN1s8Wo4sTf FU/5q/SAkbM17psfqdhxBb9Egwd6o0TiLZlqrliN+OTMEM7JlQFhU90ReWqb5v0hI1 zNR0k9Dxapjmc9TDbhI6EJdAjGFCZ7+xL/COOVQUgfH9QWVwsRVMR0cCGqL5WGCJRf QgMpQuGMHlWM9GRHdUgCjNUkOZeM2qunIMAC02bOm7dSJfL3LigxqbW3Sej4dziZfs OcNe4mQZQkvCXbBEQ60Bs37YNDZBzlpecEKOptYoyyXuTikpz/SO/jLhbpNJIiuKv5 hpZ5p9RcfcE2A== Subject: Re: [PATCH v1 1/1] iio: Drop Duplicated "mount-matrix" parameter To: Andy Shevchenko , Jonathan Cameron , Jonathan Albrieux , Jean-Baptiste Maneyrol , Lorenzo Bianconi , Linus Walleij , Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , Dan Robertson , Lorenzo Bianconi References: <20210518112546.44592-1-andriy.shevchenko@linux.intel.com> From: Sean Nyekjaer Message-ID: <66a1a5e2-181d-bcc6-b453-357fcfd5e5f1@geanix.com> Date: Tue, 18 May 2021 14:38:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210518112546.44592-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=4.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, URIBL_BLOCKED autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on 93bd6fdb21b5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/05/2021 13.25, Andy Shevchenko wrote: > All of the users of iio_read_mount_matrix() are using the very same > property name. Moreover, the property name is hard coded in the API > documentation. > > Make this clear and avoid duplication now and in the future. > > Signed-off-by: Andy Shevchenko Reviewed-by: Sean Nyekjaer > ---Good idea :)