Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Rudi Heitbaum <rudi@heitbaum.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.12 081/363] net: bridge: propagate error code and extack
 from br_mc_disabled_update
Thread-Topic: [PATCH 5.12 081/363] net: bridge: propagate error code and
 extack from br_mc_disabled_update
Thread-Index: AQHXSyXz39k+T2AuW0mkDF4mKAdj96rpK1SAgAAEIICAABNngA==
Date:   Tue, 18 May 2021 13:49:10 +0000
Message-ID: <20210518134909.iak6mdnscrcbzm6f@skbuf>
References: <20210517140302.508966430@linuxfoundation.org>
 <20210517140305.339768334@linuxfoundation.org>
 <20210518122449.GA65@ec3d6f83b95b> <YKO1jx78HibCUDkD@kroah.com>
In-Reply-To: <YKO1jx78HibCUDkD@kroah.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17EE8D362C73F9419BDBFA28D17BC493@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 442758ce-80a9-49b0-21d0-08d91a03b6e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2021 13:49:10.4024
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DvYfArVFIBmQmBJzyHwUKWq/4LXQudWQgCeJ6s4TKGwVN4ndGG5tcakyZrMDTHZ/izuRXfC9w3nnHeWE/PO1Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2685
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Greg,

On Tue, May 18, 2021 at 02:39:43PM +0200, Greg Kroah-Hartman wrote:
> On Tue, May 18, 2021 at 12:24:57PM +0000, Rudi Heitbaum wrote:
> > On Mon, May 17, 2021 at 03:59:07PM +0200, Greg Kroah-Hartman wrote:
> > > From: Florian Fainelli <f.fainelli@gmail.com>
> > >=20
> > > [ Upstream commit ae1ea84b33dab45c7b6c1754231ebda5959b504c ]
> > >=20
> > > Some Ethernet switches might only be able to support disabling multic=
ast
> > > snooping globally, which is an issue for example when several bridges
> > > span the same physical device and request contradictory settings.
> > >=20
> > > Propagate the return value of br_mc_disabled_update() such that this
> > > limitation is transmitted correctly to user-space.
> > >=20
> > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > > Signed-off-by: David S. Miller <davem@davemloft.net>
> > > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > > ---
> > >  net/bridge/br_multicast.c | 28 +++++++++++++++++++++-------
> > >  net/bridge/br_netlink.c   |  4 +++-
> > >  net/bridge/br_private.h   |  3 ++-
> > >  net/bridge/br_sysfs_br.c  |  8 +-------
> > >  4 files changed, 27 insertions(+), 16 deletions(-)
> >=20
> > This patch results in docker failing to start, and a regression between
> > 5.12.4 and 5.12.5-rc1
> >=20
> > A working dmesg output is like:
> >=20
> > [   11.545255] device eth0 entered promiscuous mode
> > [   11.693848] process 'docker/tmp/qemu-check643160757/check' started w=
ith executable stack
> > [   17.233059] br-92020c7e3aea: port 1(veth17a0552) entered blocking st=
ate
> > [   17.233065] br-92020c7e3aea: port 1(veth17a0552) entered disabled st=
ate
> > [   17.233098] device veth17a0552 entered promiscuous mode
> > [   17.292839] docker0: port 2(veth9d227f5) entered blocking state
> > [   17.292848] docker0: port 2(veth9d227f5) entered disabled state
> > [   17.292946] device veth9d227f5 entered promiscuous mode
> > [   17.293070] docker0: port 2(veth9d227f5) entered blocking state
> > [   17.293075] docker0: port 2(veth9d227f5) entered forwarding state
> >=20
> > with this patch "device veth17a0552 entered promiscuous mode" never
> > shows up.
> >=20
> > the docker error itself is:
> >=20
> > docker: Error response from daemon: failed to create endpoint
> > sleepy_dijkstra on network bridge: adding interface veth8cbd8f9 to
> > bridge docker0 failed: operation not supported.
>=20
> Ick.
>=20
> Does 5.13-rc1 also show this same problem?
>=20
> And thanks for testing!

Did you backport this patch too?
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/=
?id=3D68f5c12abbc9b6f8c5eea16c62f8b7be70793163=