Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1676698pxj; Wed, 19 May 2021 11:13:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztyn/nnS3UNS0k2cN8i3wRcydqIFqvGPhmDotMceDJxB5CcYn8mge22mR2yLoBChYbIUjA X-Received: by 2002:a17:907:76e8:: with SMTP id kg8mr434216ejc.130.1621448022396; Wed, 19 May 2021 11:13:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621448022; cv=none; d=google.com; s=arc-20160816; b=l5GNyTz5aOtiTHUZm14zQW3gGqgf7g/Pia9jUeTlyJ5WwhckqgmrFZNW2VOLqAmPws LpSzWm2ysVewb2sawVa37TXnJ0g5aCD0CEW7gZehRhrlVvtvU4LyfFN0esI6LLHpGWwr qtLlfeBnNKf+WLPoOqJcOpjVRpIrvUlXTKPME3Nw/aEc+0He3K9+c7Abh9dII/kWhasa xpIGojNWctcsuljuUykEKzIpvIB0FtE364brawKe8Eao/yAT15Exah+IFYfQfj8RI1V5 QBD/jIXLUK/iHAZyMvAZjC3w+PnsWtcbu3mcAEEUndXCQFH8YVg6Fb0Pz5pllNcvL/HV MUCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=ga/TZj/5vAgtR0dCH9rcrEvjoBQ+Qmj6N01DxKSJ5Hg=; b=ghoUHm+gHrfhL32qcwD1hVdm2ltUCVg7/+TnKcuGb0d34YFc7iNI4DKSOb95JFbn3F Na+L0w/ViagJuHpa2orZEZw+1ZceHzU97NQI3T41IEnwHxlzHnD24f0y8mqz1b+RQjsS neIGJySGsGwpWreTXVgaclUPBWGL4PeQHgkXLUFS+mRuy9Ko4n4M9tdT81jKeop/tj6W KOuYPt8VQcwzK17yYO0hdFFzBGCXLdOg9E4JRX15q8iVmDYas0BMQqXfgbbOf8cm7Ek4 GpZ50DeSsA7ZHDOp5SrC8mkGRvlyl53+PtEmH5JZF22EJSfibM2b3KFQCaVE4d1ahWgK Wbxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm3 header.b="j4U/88rH"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=jvNPXILW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp35si440434ejc.141.2021.05.19.11.13.18; Wed, 19 May 2021 11:13:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm3 header.b="j4U/88rH"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=jvNPXILW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349585AbhERNaT (ORCPT + 99 others); Tue, 18 May 2021 09:30:19 -0400 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:35483 "EHLO wnew2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349499AbhERNaR (ORCPT ); Tue, 18 May 2021 09:30:17 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 112361363; Tue, 18 May 2021 09:28:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 18 May 2021 09:28:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ga/TZj/5vAgtR0dCH9rcrEvjoBQ +Qmj6N01DxKSJ5Hg=; b=j4U/88rHJ4axiebD9NMyOxDn7M+yhUnvt/EmDkwSyBa esQ4fFKuE08eF7T+C34PKg3xxwe5uSklju7N5xhg1hmTpYYQKwgtvLPnWnFIALfL shW44ftnfabTj9n6b/fI40tc8pRWzJEHD8s5YuZ36RuUGRIsheFKE+uO45lXKTul /PE1dqbnb6mRbLsaYKsPdosXL4CbuadpovqMhFefdzmxJsA1l3dxZxFG9vVUtQU6 95A8cyvQ8KAXO3uZwSOdEb8on1m1IoDLBc0Oa8KJpB1Qdfz6dNd9DHGSHGm/Rby7 MBhsN/DHx+hwI+z59SNHzN1BtgFNHiHlKVGxcSYRXRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ga/TZj /5vAgtR0dCH9rcrEvjoBQ+Qmj6N01DxKSJ5Hg=; b=jvNPXILWdiAiOeWhZ+ZG+E gKUTpQteePibi7OTTwubqTzpzJ69i7xoHwDXvwwxsbCHYEqDrC5WX0zvmp2FyO1+ gkOdAawhDCb4Ukqln1c7us1YoHpLGws00fUFoEpFhdRgb28lXbfp5BVzUsDDnwCh 28t6mvwLdpEEo6gvqrYGyIRF5sZjYofOsvsJPpZy/tAdFsZonGrFw6ls2WdkxasC dPtxInNry9fHE2RWnpQ9X0pExERdBh7K0pL8x49Z6Nf38OTkZJBYOIY7mfuNKzIu +GPOp2/Nr23cNBASQ1pOOCTMUBabxfXShV1RU9B4sF1T4d5EB5vmT7xlQIu2XIVQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeijedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucfkphepkeef rdekiedrjeegrdeigeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 May 2021 09:28:56 -0400 (EDT) Date: Tue, 18 May 2021 15:28:54 +0200 From: Greg KH To: Faiyaz Mohammed Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, glittao@gmail.com, vinmenon@codeaurora.org Subject: Re: [PATCH v6] mm: slub: move sysfs slab alloc/free interfaces to debugfs Message-ID: References: <1621341949-26762-1-git-send-email-faiyazm@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621341949-26762-1-git-send-email-faiyazm@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 06:15:49PM +0530, Faiyaz Mohammed wrote: > alloc_calls and free_calls implementation in sysfs have two issues, > one is PAGE_SIZE limitiation of sysfs and other is it does not adhere > to "one value per file" rule. > > To overcome this issues, move the alloc_calls and free_calls implemeation > to debugfs. > > Rename the alloc_calls/free_calls to alloc_traces/free_traces, > to be inline with what it does. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Faiyaz Mohammed > --- > include/linux/slub_def.h | 8 ++ > mm/slab_common.c | 9 ++ > mm/slub.c | 359 ++++++++++++++++++++++++++++++++++++----------- > 3 files changed, 294 insertions(+), 82 deletions(-) If this is v6, what happened in v1-5? That should always be below the --- line, right?