Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbWJ1KEM (ORCPT ); Sat, 28 Oct 2006 06:04:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752048AbWJ1KEL (ORCPT ); Sat, 28 Oct 2006 06:04:11 -0400 Received: from sp604003mt.neufgp.fr ([84.96.92.56]:34742 "EHLO smTp.neuf.fr") by vger.kernel.org with ESMTP id S1752041AbWJ1KEK (ORCPT ); Sat, 28 Oct 2006 06:04:10 -0400 Date: Sat, 28 Oct 2006 12:04:10 +0200 From: Eric Dumazet Subject: Re: [take21 2/4] kevent: poll/select() notifications. In-reply-to: <11619654012104@2ka.mipt.ru> To: Evgeniy Polyakov Cc: David Miller , Ulrich Drepper , Andrew Morton , netdev , Zach Brown , Christoph Hellwig , Chase Venters , Johann Borck , linux-kernel@vger.kernel.org Message-id: <45432B1A.8020503@cosmosbay.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 8BIT References: <11619654012104@2ka.mipt.ru> User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 537 Lines: 21 Evgeniy Polyakov a ?crit : > + file = fget(k->event.id.raw[0]); > + if (!file) > + return -ENODEV; Please, do us a favor, and use EBADF instead of ENODEV. EBADF : /* Bad file number */ ENODEV : /* No such device */ You have many ENODEV uses in your patches and that really hurts. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/