Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: X0R0zvuAgcLq2gyOMf7j2M9x686tlTFxrv9qrsrgiiQ8j3Csx6K3j+F7uO985hSRsiwalgxB3d
 fE+2MP4AkRsA==
IronPort-SDR: kmGiyr+Bq3vHPT6wHBn+AK/L1D6QMQn/asQRKwONY3Li/Sl1/4ReMc4omdVFtJ+40/KWOWpPdy
 jTUpmnSGaJfA==
Subject: Re: [RFC v2-fix 1/1] x86/tdx: Handle in-kernel MMIO
To:     Dave Hansen <dave.hansen@intel.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>
Cc:     Tony Luck <tony.luck@intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Raj Ashok <ashok.raj@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        linux-kernel@vger.kernel.org
References: <3e9a26c3-8eee-88f5-f8e2-8a2dd2c028ea@intel.com>
 <20210518004807.258503-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <36cd2665-6d8b-9c0b-eec1-25152dcca2a3@intel.com>
 <43e583a3-ee2b-52d8-5275-e26a6609c126@linux.intel.com>
 <94dc5a5a-8c51-8624-5810-e6278783789c@intel.com>
From:   Andi Kleen <ak@linux.intel.com>
Message-ID: <c07e1f1e-f93d-dbc6-f7bb-11c7488f4e2f@linux.intel.com>
Date:   Tue, 18 May 2021 09:10:04 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <94dc5a5a-8c51-8624-5810-e6278783789c@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


>>>> For now we only handle a subset of instructions that the kernel
>>>> uses for MMIO operations. User-space access triggers SIGBUS.
>>> How do you know which instructions the kernel uses?
>> They're all in MMIO macros.
> I've heard exactly the opposite from the TDX team in the past.  What I
> remember was a claim that one can not just leverage the MMIO macros as a
> single point to avoid MMIO.  I remember being told that not all code in
> the kernel that does MMIO uses these macros.  APIC MMIO's were called
> out as a place that does not use the MMIO macros.

Yes x86 APIC has its own macros, but we don't use the MMIO based APIC, 
only X2APIC in TDX.

I'm not aware of any other places that would do MMIO without using the 
standard io.h macros, although it might happen in theory on x86 (but 
would likely break on some other architectures)


-Andi