Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: I4icwcyBGH0WRQL2wJT/hr+E/BqQburqg0kCTm2+SCNop0o0zioiNglfvdbfrAJCPf6e+QDgW1
 5am3FCcibibA==
IronPort-SDR: gwcrRvapQ5urxi4Wy2gp2NUyzC3i98kMC24kJg9A3btzEjKOHnjQ0KFqSEvL84tmVWOywxCo4V
 LeacXH6R2Pnw==
Subject: Re: [PATCH v6 07/16] KVM: x86/pmu: Reprogram PEBS event to emulate
 guest PEBS counter
To:     "Xu, Like" <like.xu@intel.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     Like Xu <like.xu@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, weijiang.yang@intel.com,
        Kan Liang <kan.liang@linux.intel.com>, wei.w.wang@intel.com,
        eranian@google.com, liuxiangdong5@huawei.com,
        linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org
References: <20210511024214.280733-1-like.xu@linux.intel.com>
 <20210511024214.280733-8-like.xu@linux.intel.com>
 <YKIrtdbXRcZSiohg@hirez.programming.kicks-ass.net>
 <ff5a419f-188f-d14c-72c8-4b760052734d@linux.intel.com>
 <YKN/DVNt847iEctd@hirez.programming.kicks-ass.net>
 <852ab586-2438-c7fc-c41d-0862e2f1b7ca@intel.com>
From:   Andi Kleen <ak@linux.intel.com>
Message-ID: <052e8584-fbc6-ddc7-c873-f46168aae63b@linux.intel.com>
Date:   Tue, 18 May 2021 08:58:40 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <852ab586-2438-c7fc-c41d-0862e2f1b7ca@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


>
> By "precdist", do you mean the"Precise Distribution of Instructions 
> Retired (PDIR) Facility"?


This was referring to perf's precise_ip field


>
> The SDM says Ice Lake Microarchitecture does support PEBS-PDIR on 
> IA32_FIXED0 only.
> And this patch kit enables it in the patch 0011, please take a look.
>
> Or do I miss something about precdist on ICL ?


On Icelake everything is fine

It just would need changes on other CPUs, but that can be done later.


-Andi