Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1684145pxj; Wed, 19 May 2021 11:24:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxReKuDDKP3KDjvqkXXP9fJJH4IyQWjnRvBPLAB1xrS3MX5x0uMbyRfKmKTxMwcYpTARpta X-Received: by 2002:a6b:ec19:: with SMTP id c25mr835168ioh.181.1621448675085; Wed, 19 May 2021 11:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621448675; cv=none; d=google.com; s=arc-20160816; b=giEExJT0evk4WBZPRQd5nSi7fNXlcYDSHI6ZGL9aeu9okMVSDBHZvIN1g3qAaIV5Pb /Ix/YIW95pWcaC/xkmhMQ6Wo4FD7SJ9AOBfqa0Wm6VJmsbm8/rYVaVKxP05WgNAMrIOf K9yENqzrsdHXiccTnoEp8EbGK7S89YtzA5KpqLRS/v2Pd1fk+OOSF2whiqbGuoj3lZzU aGlIyhtoHMseVnLJBJKPom0nvrEoFUX5/K4lBgd8XL9UoecVGU7PHTWcwZJ29Aky9tTS 8BcicPDzvLpsmyWiJWFHXz4zQ30BcV1Ucssnl+zbnCdK2jISGYH1XSUWj0CGFIbAAk6h QShg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IopDq1WqbzN1ym3ZNy83wMiwTcHRL4aO72eByzE4j5s=; b=YmPrKtjWJjoTcDaCwwpWnvyS1n/M5Bk6U6dQPQRpzZXhz+Q9U+zFPXjK6Peimjkb/U /q/KkK6ZEroJBcAkjgvOe4yM2br6tto9vqHdVRlS0QoZKCdy3kyEeA1e3OoewtoHOd4F 2JDK5Di2jusBbqHFA/1foWzL1LkBoLT+UVfI6/ZlDMl8S2z84QGS+xogYPPE4nqxB4Vf I4EGxSZMFCWzdlfxw7xwoUpQvK9+zNNlQJorNFHEB+PkSIrUMPBUk6JFbq5o7PyBfm7r SXpYz40Aqh+RBytb6XoZlc69akPwF0ccmImcHOiNOe8cFl85Q4cdhmwZ6Dx/VqPv5M/h 9AZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fBSqlS7i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si419502ili.90.2021.05.19.11.24.22; Wed, 19 May 2021 11:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fBSqlS7i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345149AbhERQnk (ORCPT + 99 others); Tue, 18 May 2021 12:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243086AbhERQnj (ORCPT ); Tue, 18 May 2021 12:43:39 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9144C061573 for ; Tue, 18 May 2021 09:42:21 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id x18so3523169pfi.9 for ; Tue, 18 May 2021 09:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IopDq1WqbzN1ym3ZNy83wMiwTcHRL4aO72eByzE4j5s=; b=fBSqlS7iKRbQlaPtPvcRcqFedGqriKZ0I7iud8U3gRqBOVhpPX28ne0L8CIfBsDA41 muD0rtjvfEQl7tvPCwGp8hKU4uYq1wJPqCJANEKknkoHaegpleblGSfdpjsw1LPqxolN RgShh/td5WlLdoT4xWOKjTexpy+QwMs/Bnc1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IopDq1WqbzN1ym3ZNy83wMiwTcHRL4aO72eByzE4j5s=; b=MB9T3RHBJrsn5cXIhyLm812T8b5WRJ20oxzAbB9l+JnzCjoTz5SxSPDomQOlc3O89s 6BrokSbDIgKetCjNqrAvffnHgVJxuBV9Hy/EprBEj9L0NqiiqDBJU0YajZzXjmVcDfJw HKaXRS/mAbDCpfRdYQq2bTgAxFE/+NZHSDJSg3XJ3qm8pipWV6h02CqQxmSGqET3wHWO KpzLeb/LokaVd7SqTLTKqYu0rnCCPpjWcTqRvgolg2glmfZIk34rTzVMTjh9YN+DjnmA A4uvHBppmksdgcdiOpayVq/FhpbELyDi0iyS7jcXSLTeyT9kK6r3dapyWlN1/1HvuAu2 NRuQ== X-Gm-Message-State: AOAM5307HA+CPuT3PTpt8yNjCqh1yKM/wtWnFK1JiAncQ+cbSgCdWH62 NlRMiC6bW69n0ufq3YEvAxvVOw== X-Received: by 2002:a62:7e41:0:b029:249:287:3706 with SMTP id z62-20020a627e410000b029024902873706mr5860061pfc.76.1621356141265; Tue, 18 May 2021 09:42:21 -0700 (PDT) Received: from localhost ([2620:15c:202:201:5b64:c814:4f8b:838e]) by smtp.gmail.com with UTF8SMTPSA id h26sm4289692pfo.203.2021.05.18.09.42.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 May 2021 09:42:20 -0700 (PDT) Date: Tue, 18 May 2021 09:42:19 -0700 From: Matthias Kaehlcke To: Vinod Koul Cc: satya priya , Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgunda@codeaurora.org Subject: Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file Message-ID: References: <1621318822-29332-1-git-send-email-skakit@codeaurora.org> <1621318822-29332-4-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote: > On 18-05-21, 11:50, satya priya wrote: > > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes. > > > > Signed-off-by: satya priya > > Reviewed-by: Matthias Kaehlcke > > --- > > Changes in RESEND V4: > > - No Changes. > > > > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi > > > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi > > new file mode 100644 > > index 0000000..e7f64a9 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi > > @@ -0,0 +1,53 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +// Copyright (c) 2021, The Linux Foundation. All rights reserved. > > + > > +#include > > +#include > > + > > +&spmi_bus { > > + pm7325: pmic@1 { > > + compatible = "qcom,pm7325", "qcom,spmi-pmic"; > > where is qcom,pm7325 documented? good point, I missed that one. > > + reg = <0x1 SPMI_USID>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pm7325_temp_alarm: temp-alarm@a00 { > > + compatible = "qcom,spmi-temp-alarm"; > > + reg = <0xa00>; > > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > > + #thermal-sensor-cells = <0>; > > + }; > > + > > + pm7325_gpios: gpios@8800 { > > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio"; > > where is qcom,pm7325-gpio documented? It's added by the 'Add GPIO support for PM7325' series (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=481133) The binding change was acked by Rob and the code by Bjorn, so it can be expected to land, but it would still be good to mention the dependency explicitly.