Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7c09a6bf2ee0a644863f1ec8b333c871cf83d5b8.camel@redhat.com>
Subject: Re: [PATCH] usb: typec: ucsi: Clear pending after acking connector
 change
From:   Benjamin Berg <bberg@redhat.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 18 May 2021 20:04:14 +0200
In-Reply-To: <YKPBPqZ6zHBsCnsO@kuha.fi.intel.com>
References: <20210516040953.622409-1-bjorn.andersson@linaro.org>
         <YKI/XT8qpZDjDuqs@kuha.fi.intel.com> <YKJeYzIgvL/soGgw@kuha.fi.intel.com>
         <cd62e9a6d317e106db5e5d6b5f36170524ed7ad9.camel@redhat.com>
         <YKPBPqZ6zHBsCnsO@kuha.fi.intel.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-8Z+unxOuqkr2aCvCa/tM"
User-Agent: Evolution 3.40.0 (3.40.0-1.fc34) 
MIME-Version: 1.0
Precedence: bulk


--=-8Z+unxOuqkr2aCvCa/tM
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2021-05-18 at 16:29 +0300, Heikki Krogerus wrote:
> On Mon, May 17, 2021 at 02:57:28PM +0200, Benjamin Berg wrote:
> >=20
> > [SNIP]
> > Unfortunately, I don't feel it'll work. The problem that I was
> > seeing
> > looked like a race condition in the PPM itself, where the window is
> > the
> > time between the UCSI_GET_CONNECTOR_STATUS command and the
> > subsequent
> > ACK.
> > For such a firmware level bug in the PPM, we need a way to detect
> > the
> > race condition when it happens (or get a fix for the firmware).
>=20
> OK. Let me know does the patch bring the issue back for you.

So, I just tried the patch, and I can occasionally reproduce the issue
where "online" for the ucsi power adapter is stuck at "1" after
unplugging with the patch applied.

Benjamin

--=-8Z+unxOuqkr2aCvCa/tM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEED2NO4vMS33W8E4AFq6ZWhpmFY3AFAmCkAZ4ACgkQq6ZWhpmF
Y3CUXQ/+JPiXi/zXLZ1HUWY+VnsNNMv4cFtjtbtcc1AapCU34szVwLnwuycWtBpO
1wHuiAH4SV+YwFEn5w2qNv4KI268p7bKZPiAtAcohloNGfC45TJ7GCVZmGzIE98I
7nsIyfiB0IgQBAh5LDf7M8WTyANQgrPqx4urq7jBWdPX9vrqvELnNKK6awfuYFJe
3MZVfWwM94JEZ40TcQPfLpO35Wth4ZN7B9BimMD8ZmqoXri9cHxnJQXE9/LtXEht
rM5JTItnd4V1V84ytPfy62GblTR0DhHjAWpDKYU03kKH6F11qj0usNd3D1lpWabo
rr1dFup7h85iJxHH5FaBqGWFBJu4Vi0jU4/q/lGPde2uGxnPI2v+vSMtFzzCEJer
mThkDvLZAIik+f7Gpv4qAF1Rmi7E5xFVQfHV7Pi2ntQCJDKPlf6bvL6PAu8ICwIf
aXvInWh7pROGtxkA41GPc/fzKBOL/kZcxcBPokp+JOWNoM2/XF3zN9v7mN0GeNqr
uKz43aclO5qi+dI/H21EBNi3rIuCN64yS1GTq65aa4KkGBcyPjzGo+5BYQ34pmkl
gVp/oWOqNMhBkh6w+FE9CrDxiNUEqpPYK5ND8FMmsMHorQybkP+k0Cp7ff7f+chw
TxQcBPQQUZBlLMAuz2l23eVk4vFKFtHQOJ6nd7lQwonjF++u7ds=
=NiPb
-----END PGP SIGNATURE-----

--=-8Z+unxOuqkr2aCvCa/tM--