Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1690468pxj; Wed, 19 May 2021 11:33:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhZrzgAJr3JkdM536hEfUQeRDWewgopsF8G35lgzICnfShC9WvpvhVyWXoOd+7b2iiyRNs X-Received: by 2002:a17:906:fcb4:: with SMTP id qw20mr539705ejb.216.1621449180354; Wed, 19 May 2021 11:33:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621449180; cv=none; d=google.com; s=arc-20160816; b=iiOyTBdKbAGNLM62opNWklgN4O9WdNq0wWTusFlFnTAn9pUa1BAuw5UshIHpdDiCVU 6lfUJoe790V923EA8DQllBQEJFCIA/tBiVtLhD9VZ2cdULlh2LU9S3SRlwTeknZSb+v3 zb1VZzVZtW9LbFIDjxFMRGN63bDrtwl8eZr+Ms+GhdFfaMH/5VEFt5K5soDwoDkh25Pr IgV4becdvfq/MZ5wZ1G5Z8Ge7D5IuOY4ZoekNmO6JiHnbpZmV02Paq9vzTe5mPBH2jF4 ZNTSDSeMzaFxtp+BbDpH/9fdb6gHsFq9VPyhypKvRxK6LO8KwGUAo2PqwpHGDGguRgJt eKHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9yb6X9WCq6ingF8cwtbx1O7/WjF/mpD5c/jdXsDaiW8=; b=osbEhucQd000FzRCWUxM6gR+RwJdraGvdol7Vn46cj3/QPYYDHf2XrhGqBW0adOunr f63FFFkD0SOzwko8NTVDj/qkXteX1LB/nnDbgoHo2wr2YxLSI2h/HuVTx9VuabBNWYJH WgjhOelAnAWsxEXZ7nSAo6GuPxdaz6syPRCiSUUz69ufWOxiFSKQZgDcBGzno1KoyhxO A+FMhee9tns0CVxm2uR31bcXvVzNsfMXacFh1hJ+N+xgd+FkUEsIXq+7lLxKB0pVCH9H WBJKd2uXbTmie6QKPqyuGV6JhVGKRG7GxAlx7Vgz9rMqnDRMPrRBIGi2V7ROuavZwKzk pv7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=gFus+75B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si383666eju.490.2021.05.19.11.32.37; Wed, 19 May 2021 11:33:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=gFus+75B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351762AbhERTXH (ORCPT + 99 others); Tue, 18 May 2021 15:23:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351794AbhERTXG (ORCPT ); Tue, 18 May 2021 15:23:06 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30CEFC06175F for ; Tue, 18 May 2021 12:21:48 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id c17so8156227pfn.6 for ; Tue, 18 May 2021 12:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9yb6X9WCq6ingF8cwtbx1O7/WjF/mpD5c/jdXsDaiW8=; b=gFus+75BX7d39Z9zBEPrdYyp79FrQv1jUMPYm2ohAEJtCBHKTsJ1GqCIzPrKBl3QUz Q1T0JWWgL3GlIbuGhpOcHFlaUuT6zzUtFwSFsYdUpiYcSV6+tQQpFs4KyH5vB+sw3i8v RbYtaOy9+KQ3pQtOzXb8DvCMdQBnrQc5WOqaUd0fIsYYlyVBrySVf05ZA3awm5lS0gBh rYb9Ia1yuY5szSvQddMu+sBq+JgxSlkM4vSmOyDe7PXVUjHUXncr7ynLwjCI44MdLIlM Mln1juREPPPbXVkNHh5yuzLiF91QanUBhmnZWT6zz24VkOYci18iKrJbag3oG4wnGB1g iTUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9yb6X9WCq6ingF8cwtbx1O7/WjF/mpD5c/jdXsDaiW8=; b=H96GRcwyPeU7n+qT5FeD50xdoYyQo8JYFbbUjnRBN+RamET9hzS5gPaBTgGEtFCjNK iF/+3eX99Cl304qf/BnD1cstGe4Xz6WDILnVu8zOxa94G1C1ZJYS1ItqsbSERrX3cuNT vSlTMuT8BvXb9H6f4Ps3fpSfUG/P/kIOLN3SDjZIi/cDRBzoV5TS+1qvYEUMfoT8QACk VCPQ/Q565XUJiQJHLElPaEkl8tjv4ngZhIBwwDt0EOorKiZJ23oP1qKHsg1HywpvGuhn zDzFAKvOzUS5qXDt7aRj2482pLtRrBJKT6NzPFHdX/mXlGNTEpE631LBp++UFzM5UaRI wGaA== X-Gm-Message-State: AOAM532L7eWu7kUwq7HzZjWzcMt3tWJOoncquejZXKxgiUED66KHhBWG pm8eQnG8U8s9IwDe0LS48Vj0iQ== X-Received: by 2002:a63:f245:: with SMTP id d5mr6584667pgk.416.1621365707487; Tue, 18 May 2021 12:21:47 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id o4sm12990504pfk.15.2021.05.18.12.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 12:21:46 -0700 (PDT) Date: Tue, 18 May 2021 19:21:43 +0000 From: Sean Christopherson To: Wanpeng Li Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel Subject: Re: [PATCH v4 2/5] KVM: X86: Bail out of direct yield in case of under-committed scenarios Message-ID: References: <1621339235-11131-1-git-send-email-wanpengli@tencent.com> <1621339235-11131-2-git-send-email-wanpengli@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621339235-11131-2-git-send-email-wanpengli@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021, Wanpeng Li wrote: > From: Wanpeng Li > > In case of under-committed scenarios, vCPU can get scheduling easily, > kvm_vcpu_yield_to add extra overhead, we can observe a lot of race > between vcpu->ready is true and yield fails due to p->state is > TASK_RUNNING. Let's bail out in such scenarios by checking the length > of current cpu runqueue, it can be treated as a hint of under-committed > instead of guarantee of accuracy. The directed_yield_successful/attempted > ratio can be improved from 50+% to 80+% in the under-committed scenario. The "50+% to 80+%" comment will be a bit confusing for future readers now that the single_task_running() case counts as an attempt. I think the new comment would be something like "30%+ of directed-yield attempts can avoid the expensive lookups in kvm_sched_yield() in an under-committed scenario." That would also provide the real justification, as bumping the success ratio isn't the true goal of this path. > Signed-off-by: Wanpeng Li > --- > v2 -> v3: > * update patch description > v1 -> v2: > * move the check after attempted counting > * update patch description > > arch/x86/kvm/x86.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 9b6bca616929..dfb7c320581f 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8360,6 +8360,9 @@ static void kvm_sched_yield(struct kvm_vcpu *vcpu, unsigned long dest_id) > > vcpu->stat.directed_yield_attempted++; > > + if (single_task_running()) > + goto no_yield; > + > rcu_read_lock(); > map = rcu_dereference(vcpu->kvm->arch.apic_map); > > -- > 2.25.1 >