Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ETTd9l75Yq7Mbo0EZGPL9AxJ5wcEcuNG6B87Y+PGCAAlY+fhUh6CsKCZrdMKbnz6hABZnhD3ab
 u7dg5mMTnpQ/XOzBhiMs+S7wspSF0VGBCEfF824OR6bNY8qi7e2o3Cm5l16CQhIjciqlU+aDaD
 6rnZkMnwpst85jgPbCIhPQqdqtHx3qmKDo91d5/OkGx8pYHY1xy6AkysLObExk3Jbw0wrnO3Rz
 5G8Y966TK/tWrkooR4A4UtUZa6EmlX5A4b//SnQHy1AotNAgxWYH7BTKZRKNIXqUfhZk7eEJ5M
 CMo=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Wu Bo <wubo40@huawei.com>, "kbusch@kernel.org" <kbusch@kernel.org>
CC:     "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
        "amit.engel@dell.com" <amit.engel@dell.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linfeilong@huawei.com" <linfeilong@huawei.com>
Subject: Re: [PATCH] nvmet: fix memory leak on nvmet_alloc_ctrl()
Thread-Topic: [PATCH] nvmet: fix memory leak on nvmet_alloc_ctrl()
Thread-Index: AQHXS77BXPlsENBRfkCDAiaeiYCKqg==
Date:   Tue, 18 May 2021 20:27:43 +0000
Message-ID: <BYAPR04MB4965E8D55C4349EC01EF61FB862C9@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <1621327598-542045-1-git-send-email-wubo40@huawei.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 27d7066c-26b9-4ed8-6c5e-08d91a3b6452
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2021 20:27:43.7092
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ULyJbF6vH9EYXN0ByH7qOawqw94yru0HOGJKkbpkzfq52PdpznWm15lFWZIyijsb9w9MmuRMIzN12Q6PLTz3PwULitS+4ngXp1MdvNRZpSY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5029
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/18/21 01:21, Wu Bo wrote:=0A=
> From: Wu Bo <wubo40@huawei.com>=0A=
>=0A=
> When cntlid_min is greater than cntlid_max,=0A=
> goto wrong label, should be goto out_free_sqs=0A=
> label. Otherwise there is a memory leak problem=0A=
> on the nvmet_alloc_ctrl function().=0A=
>=0A=
> Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")=0A=
> Fixes: 6d65aeab7bf6e ("nvmet: remove unused ctrl->cqs")=0A=
> Signed-off-by: Wu Bo <wubo40@huawei.com>=0A=
> ---=0A=
=0A=
Looks good, except commit message could be better :-=0A=
=0A=
When cntlid_min is greater than cntlid_max, goto wrong label, should be=0A=
goto out_free_sqs label. Otherwise there is a memory leak problem on the=0A=
nvmet_alloc_ctrl function(). =0A=
=0A=
Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")=0A=
Fixes: 6d65aeab7bf6 ("nvmet: remove unused ctrl->cqs")=0A=
Signed-off-by: Wu Bo <wubo40@huawei.com>=0A=
=0A=
=0A=
with above :-=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
=0A=