Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1697328pxj; Wed, 19 May 2021 11:43:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyys8jJ3nIsx7V0nXOYcHQxGRWZNLiHLHA1ebC+Dvk0LZuSn9ubgCZvvw0fO7scTHUl2auO X-Received: by 2002:a17:907:72c3:: with SMTP id du3mr583450ejc.194.1621449790323; Wed, 19 May 2021 11:43:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621449790; cv=none; d=google.com; s=arc-20160816; b=NxvScweGrO9uJAVsueg1tt0C78kxyJykro9QLncNu5v6snWcH/HpJn18rw8akwtmu4 OuHmIfKgGYT4TVl0wtK/rY/AhuTyeZWwRqpvVV5chuMen0yBCvkE11JQ3J3gNIVA0jqt 6P0Qgr50WR8Brf+rbxHQV+2CyqCuhLvdoZtkRlfwga2g/9/jAZtzynpDa0h78aTTqlPm z8goRue78FscRkRDrq93OghlC3WZRRJsx266SL4HWb7Q/k2otF/8/PhZgUO/AS6L2MqB ZNtd2yTlyhVplaWG2cb5nIlkf4CewrJl9y84jYomAvo+fSc47TPdypScju6adIBzmXMp Y2Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=PUf9XT5CCu/J0Hg+9JaJkiWdRUNebcIzPzoiO7Euexs=; b=oXFJWejYlROicnTPZUVVJQTovhG/3v1ke8RXvoCjLqGPyBO5Q6VHTrzQBBmRyLhnNi cZrx9vA6AFqUhiuBFzEx4xgZDH625ZhoT0dI78r4ouzgPIj9WY/jPyZOg6IbEIzMMFWi ZQrqUbedlEpSlEFPvS9s4t+YJrfV/QhNhVsPRQZ5RhxB8bM+zPWgW/NDhzP3wE/d5qRp YJKjQaSuZVw5jSQbdDRYy8NCowf1oHeUG1T9MteM0Kz8ZmxpwCRngK+G9/OcuJbw/wur JAVIfYO/wKUcXceG9QR0LeGKtYSMuGpazIRwbq01GkGEBRins5ZnF16GplojRcG9UzCW b4Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cojriOor; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc10si283764ejc.734.2021.05.19.11.42.46; Wed, 19 May 2021 11:43:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cojriOor; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352724AbhERWVd (ORCPT + 99 others); Tue, 18 May 2021 18:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352722AbhERWVa (ORCPT ); Tue, 18 May 2021 18:21:30 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1934C061573 for ; Tue, 18 May 2021 15:20:10 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 131so13262520ljj.3 for ; Tue, 18 May 2021 15:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PUf9XT5CCu/J0Hg+9JaJkiWdRUNebcIzPzoiO7Euexs=; b=cojriOorSV9jnlpm7gCjTmIpC1epvLKbDT76cfaCHIptdXb9gsx9TdmRTwg5hj89iP dARDZ9H2Tivs976nEnFnp9wSBdutmcunp0dqJryoPWeLeuvpnB7225Nmrf3GrzNE8JAC f2nnC2vXS1s2P2N78ymYCl8kqGuh/HgAbVaj2ziqXbw4kQEVLFaSLX2xjdXq4svKLy4O wUJdyKti/FOxbOYt/um2BrCJHKZ2sFJYX9n1RAPalWem3r9tSlrfDsFWoMeRnjQ6kk7l HvqKu7lOJHIXEqIg0l+xWSQHmWqgzxRhm16oWfA+n/gy5axoeeff2hUs1pHKWg4NVWm6 RLXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PUf9XT5CCu/J0Hg+9JaJkiWdRUNebcIzPzoiO7Euexs=; b=aag7kXHUw8W2B6ZEMUwmdcwZpfgEruAeY1UjwQtHCCPAxWSEAIzLJHtsth079+rXA6 Rb8gN28YbR4mBVoDIzj51rzAXVHL3RbOH3PyJUwVg4ds/MhgJL1NmdBMPvpFXg6GDIW+ esu92wr/DyxLW4y/hhD4Dqr9Vx/0e3IQgDdD4FeQY9/97fwUbJC1OimTkelK+t6pxwwa nRuFVgBQrfwjLXSl5qMp8wQBh9/RDk18d8eJ8DeKCdK0vn8EjByXDdKEw+FnoO/D0ATx F1D9/VcWYoT2zfRcUDofZRzkWksqQB5TmOp1PIUwR6b9CpQxk/OVZ8J93UkSCKx4N5+u 1GlQ== X-Gm-Message-State: AOAM5309zQVgUW1wzHRC9e/N990O314pWjQqpz30rTTl1i7vEfypKG4d MBW6sDvcleX/QLV6fuut7/mAB3jA4ibVDasQnFDuhw== X-Received: by 2002:a2e:90c7:: with SMTP id o7mr5791882ljg.368.1621376409523; Tue, 18 May 2021 15:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20210518120633.GW12395@shell.armlinux.org.uk> In-Reply-To: From: Linus Walleij Date: Wed, 19 May 2021 00:19:58 +0200 Message-ID: Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start To: "Russell King (Oracle)" , Nicolas Pitre Cc: Yanfei Xu , Mike Rapoport , Ard Biesheuvel , Andrew Morton , Hailong liu , Tian Tao , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 2:15 PM Russell King (Oracle) wrote: > Change the current vmalloc_min, which is supposed to be the lowest > address of vmalloc space including the VMALLOC_OFFSET, to vmalloc_start > which does not include VMALLOC_OFFSET. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Linus Walleij > +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20); When I first read this it took me some time to figure out what was going on here, so if you have time, please fold in a comment with some explanation of that (240 << 20) thing, in some blog post I described it as "an interesting way to write 0x0f000000" but I suppose commit 0536bdf33faf chose this way for a specific reason? (Paging Nico if he can explain it.) Yours, Linus Walleij