Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1697872pxj; Wed, 19 May 2021 11:44:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9Gm31jsFgRBGgGv9JmckDDBBpVEOUY5ye1NlfXR6zH2XXox5LknVvTVww8Bm7xcx6kYs9 X-Received: by 2002:a05:6402:1d3c:: with SMTP id dh28mr468654edb.129.1621449841454; Wed, 19 May 2021 11:44:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621449841; cv=none; d=google.com; s=arc-20160816; b=Zm+EJentOlmgWFU0VAS27LXJCIo3kggtBu1njyGOHq3Ba7AnZIeaUecmnyQHAhfT7o h+2dnldGmiW6tt03/OLhBIR8NWjisGFjSGojEwuSlJwKGTiLqTcN9svKM8l9G0uiCD9q 2I0DyYoTwZRceEb1lJtLVf9MYFBVFTYQz8DLRaX/L09ZI9DEut/Lu30Bt+ip8VkwDlfB IxsgXh2o/A2KkXZIHEs8JpV061/o/g+Ah2p8bS1TXbgnQeJDFrTnDU4Az5OMvpcdx9R8 b+cV5FlxfwBKUWEoQAejO4kIpbgzwxbzINwySz9kI6/Hp5ZJHrEeXoAq9ARSOfpJRmP4 Jnjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=XsnH1xAY5SnrpmcWGhe1yefQAVG+cpkY+Rq3AlPAe4E=; b=J1KhcOHU6q4CO1q5td29cMUCo3bxq5WM6SYRM5yV8/eMJjGz4UwMELDFlvyXbcYHVm ooPX/ip9G2OjWq2+c3bEo6MSMBTX8KtJToQcP/bNzuNIECtwsMrUw+FHry9hF/2X5onn 6FlesjaBYKOJqi4AH/+yGUPKxf5JvRIr9W+LGCrI6WyKLUkqBvRa6vjJn9iwC2Qi9JGv Eu26ChAJeV159Fvnpaf6ovmJEoapgEbVgYM27702YGrNRNAfg+1ztGfsabwXL2MJhUq6 /fwMkcNj9Sa96p991kipzTLeqqwCOc0hR4+tvtZz4ePdxiJkPIK1Xx4dzpBy4Fp2EOql zBLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fx13si334827ejb.602.2021.05.19.11.43.37; Wed, 19 May 2021 11:44:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352756AbhERWd1 (ORCPT + 99 others); Tue, 18 May 2021 18:33:27 -0400 Received: from mga18.intel.com ([134.134.136.126]:43856 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237154AbhERWd0 (ORCPT ); Tue, 18 May 2021 18:33:26 -0400 IronPort-SDR: 0AKGjXjITwaCIWogiSAgKBCqlPdsf7n2KeLuK2+ySjYSCc4K0Y4DaTQGA1tfCtLUkZ5D7t0oOx pY8HWrxfvdLw== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="188247135" X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="188247135" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 15:31:51 -0700 IronPort-SDR: 8U5S8hYSriIPi/gZaFWO+9xVutNW5JvYrpmgC3OQ7CxFP8z/ERZ2ZNm6N/lzXru+OHvvJj++CL whtXtmB8ShGA== X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="542156624" Received: from craigsmi-mobl.amr.corp.intel.com (HELO [10.212.132.228]) ([10.212.132.228]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 15:31:50 -0700 Subject: Re: [RFC v2-fix 1/1] x86/tdx: Make DMA pages shared To: "Kuppuswamy, Sathyanarayanan" , Sean Christopherson Cc: Peter Zijlstra , Andy Lutomirski , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Dan Williams , Raj Ashok , linux-kernel@vger.kernel.org, Kai Huang , Sean Christopherson References: <1ccf5e60d2d79308d50f93c8c3b32b1394bc7baf.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com> <20210518011912.259112-1-sathyanarayanan.kuppuswamy@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <3f392477-12b9-ff16-8e32-b00b6593d82a@intel.com> Date: Tue, 18 May 2021 15:31:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/21 3:12 PM, Kuppuswamy, Sathyanarayanan wrote: > "TDX is similar. In TDX architecture, the private guest memory is > encrypted, which prevents anything other than guest from > accessing/modifying it. So to communicate with I/O devices, we need > to create decrypted mapping and make the pages shared." That's actually even more wrong. :( Check out "Machine Check Architecture Background" in the TDX architecture spec. Modification is totally permitted in the architecture. A host can write all day long to guest memory. Depending on how you use the word, "access" can also include writes. TDX really just prevents guests from *consuming* the gunk that an attacker might write. Also, don't say "decrypted". The memory is probably still TME-enabled and probably encrypted on the DIMM. It's still encrypted even if shared, it's just using the TME key, not the TD key.