Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1705118pxj; Wed, 19 May 2021 11:56:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/jhBgVlLX9NQAUhRPexFPGlkPGHPV2fVmN8L/Kp+iNLpEXmp5LOrtOJrhTP/aNyF03zm+ X-Received: by 2002:a05:6402:3494:: with SMTP id v20mr506608edc.169.1621450603573; Wed, 19 May 2021 11:56:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621450603; cv=none; d=google.com; s=arc-20160816; b=KlIWVLm6ApqdRoAgckfHk1ftgMy3evtOhqrVNPrP52P6d0uancp5+OX7JV5+TIlphS MCQ1i78OhcPEnCli1WHel9LG26x4u3yB7OSfTGsX6RBnjG6wxPm3Zm/jZ9ibEM3P7eaA kHjUHfM/fHWQ3jqU8lixAV68+7h9Hs2scsGvEHs5iMiOligYK1IWmzU+CTWMt+FIhh/h O+bpRItzgtoLofJ8oOUNQQBxoBN5Ox5Phzlh3yeu5ADqitb7lxddUpYHS7qqz6TH0+f7 GftCoY3QAdbCCZEj0RKLXs7JJRWeXaeLsYCVsuz/QVkDHfD4smWuP25phALzIDHub7ZQ AspQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PXQqZShAKLsePZjHI++41Hv/ebG6d8ggMWeVfRhScX4=; b=NFwMjCv+6cRWq4BdyeUD6L9vqayvfIsqilecPnOc0Nl/BwN5NKL38vTNiKRxiAChgT 5K8fSbx/p7bCoDMcSyUgmoJMdTkDJpRxZqjTePAOx39VjriFfEc6qmuiH9i/kzkdNHuo +h0QZnAvN8vUCm/R7QkDS3mx9ph9azjjj6dnRTQVtrn0NCnyZLvAskB8HEUNnMkE24mx 5WOMWUSUfn9zuduXKYzO5Vl7yIwKWwCrvqwDdV2D7q71ujg4K1smaCLgrxt4u703mEth +h6hwzA7gIF7PNQQMwMOYyA7LNap8DQC1ay6UMOfClUVDB7cDv7euUdgJeGGqb6XaM7H /IFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si487058ejc.125.2021.05.19.11.56.19; Wed, 19 May 2021 11:56:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352900AbhESAw1 (ORCPT + 99 others); Tue, 18 May 2021 20:52:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234763AbhESAu5 (ORCPT ); Tue, 18 May 2021 20:50:57 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E6E2C061760; Tue, 18 May 2021 17:49:38 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1ljAOU-00G4Fm-Bt; Wed, 19 May 2021 00:49:02 +0000 From: Al Viro To: Linus Torvalds Cc: Jia He , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "Eric W . Biederman" , "Darrick J. Wong" , "Peter Zijlstra (Intel)" , Ira Weiny , Eric Biggers , "Ahmed S. Darwish" , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-s390 , linux-fsdevel Subject: [PATCH 10/14] d_path: prepend_path(): get rid of vfsmnt Date: Wed, 19 May 2021 00:48:57 +0000 Message-Id: <20210519004901.3829541-10-viro@zeniv.linux.org.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210519004901.3829541-1-viro@zeniv.linux.org.uk> References: <20210519004901.3829541-1-viro@zeniv.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org it's kept equal to &mnt->mnt all along. Signed-off-by: Al Viro --- fs/d_path.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/d_path.c b/fs/d_path.c index 06e93dd031bf..3836f5d0b023 100644 --- a/fs/d_path.c +++ b/fs/d_path.c @@ -90,7 +90,6 @@ static int prepend_path(const struct path *path, struct prepend_buffer *p) { struct dentry *dentry; - struct vfsmount *vfsmnt; struct mount *mnt; int error = 0; unsigned seq, m_seq = 0; @@ -105,18 +104,17 @@ static int prepend_path(const struct path *path, b = *p; error = 0; dentry = path->dentry; - vfsmnt = path->mnt; - mnt = real_mount(vfsmnt); + mnt = real_mount(path->mnt); read_seqbegin_or_lock(&rename_lock, &seq); - while (dentry != root->dentry || vfsmnt != root->mnt) { + while (dentry != root->dentry || &mnt->mnt != root->mnt) { struct dentry * parent; - if (dentry == vfsmnt->mnt_root || IS_ROOT(dentry)) { + if (dentry == mnt->mnt.mnt_root || IS_ROOT(dentry)) { struct mount *parent = READ_ONCE(mnt->mnt_parent); struct mnt_namespace *mnt_ns; /* Escaped? */ - if (dentry != vfsmnt->mnt_root) { + if (dentry != mnt->mnt.mnt_root) { b = *p; error = 3; break; @@ -125,7 +123,6 @@ static int prepend_path(const struct path *path, if (mnt != parent) { dentry = READ_ONCE(mnt->mnt_mountpoint); mnt = parent; - vfsmnt = &mnt->mnt; continue; } mnt_ns = READ_ONCE(mnt->mnt_ns); -- 2.11.0