Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: cWbROLAAY2Fe36BfQQYtIafWUy9/oOCKM62c2S4R96hidEG7VAQGgDclnrbo8FUDclL0y1CHAs
 PBBJ8LsLIotw==
IronPort-SDR: rbL3kQZR1uynevmpi5klN6bFZqhRIj9jffrR0XEI/JhlUIhDrP2FiSGGnbt8aheo54aDFtYtXE
 4KzoShoIUk2Q==
From:   "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>
To:     Russell King <linux@armlinux.org.uk>
CC:     "Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
        "alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "Tan, Tee Min" <tee.min.tan@intel.com>,
        "vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 2/2] net: stmmac: Add callbacks for DWC xpcs
 Energy Efficient Ethernet
Thread-Topic: [PATCH net-next 2/2] net: stmmac: Add callbacks for DWC xpcs
 Energy Efficient Ethernet
Thread-Index: AQHXSwHXH3A7a02UTEaLpjsECGhB/Krnf/sAgAAJ7wCAAXsAgIABERPw
Date:   Wed, 19 May 2021 02:27:15 +0000
Message-ID: <CO1PR11MB5044577A1B810577AFB25D8E9D2B9@CO1PR11MB5044.namprd11.prod.outlook.com>
References: <20210517094332.24976-1-michael.wei.hong.sit@intel.com>
 <20210517094332.24976-3-michael.wei.hong.sit@intel.com>
 <20210517105424.GP12395@shell.armlinux.org.uk>
 <CO1PR11MB50447EDBEB4835C3EB5B3C7A9D2D9@CO1PR11MB5044.namprd11.prod.outlook.com>
 <20210518100627.GT12395@shell.armlinux.org.uk>
In-Reply-To: <20210518100627.GT12395@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c8bdb11e-8845-4fb5-609b-08d91a6d9e79
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2021 02:27:16.0405
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DmNC21fHiu7LjJ9TM9Ip+Xn5VESGLkuglVLtJ19fhnHH5RcTevF1NmofWQ3bRuX4xj5umY4SN1o9OaInlOTrT9vcU8OcPw5iwvGFAkt3ND4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1709
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Russell King <linux@armlinux.org.uk>
> Sent: Tuesday, 18 May, 2021 6:06 PM
> To: Sit, Michael Wei Hong <michael.wei.hong.sit@intel.com>
> Cc: Jose.Abreu@synopsys.com; andrew@lunn.ch;
> hkallweit1@gmail.com; kuba@kernel.org;
> netdev@vger.kernel.org; peppe.cavallaro@st.com;
> alexandre.torgue@foss.st.com; davem@davemloft.net;
> mcoquelin.stm32@gmail.com; Voon, Weifeng
> <weifeng.voon@intel.com>; Ong, Boon Leong
> <boon.leong.ong@intel.com>; Tan, Tee Min
> <tee.min.tan@intel.com>; vee.khee.wong@linux.intel.com;
> Wong, Vee Khee <vee.khee.wong@intel.com>; linux-stm32@st-
> md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 2/2] net: stmmac: Add callbacks for
> DWC xpcs Energy Efficient Ethernet
>=20
> On Mon, May 17, 2021 at 11:37:12AM +0000, Sit, Michael Wei
> Hong wrote:
> > > From: Russell King <linux@armlinux.org.uk>
> > >
> > > On Mon, May 17, 2021 at 05:43:32PM +0800, Michael Sit Wei
> Hong
> > > wrote:
> > > > Link xpcs callback functions for MAC to configure the xpcs
> EEE
> > > feature.
> > > >
> > > > The clk_eee frequency is used to calculate the
> > > MULT_FACT_100NS. This
> > > > is to adjust the clock tic closer to 100ns.
> > > >
> > > > Signed-off-by: Michael Sit Wei Hong
> > > <michael.wei.hong.sit@intel.com>
> > >
> > > What is the initial state of the EEE configuration before the
> first
> > > call to stmmac_ethtool_op_set_eee()? Does it reflect the
> default EEE
> > > settings?
> >
> > The register values before the first call are the default reset
> values
> > in the registers. The reset values assumes the clk_eee_i time
> period
> > is 10ns, Hence, the reset value is set to 9.
> > According to the register description, This value should be
> programmed
> > such that the clk_eee_i_time_period * (MULT_FACT_100NS + 1)
> should be
> > within 80 ns to 120 ns.
> >
> > Since we are using a fixed 19.2MHz clk_eee, which is 52ns, we
> are
> > setting the value to 1.
>=20
> Does that hardware default configuration match what is returned
> by ethtool --show-eee ?

May I know what is the hardware default configuration that is expected
to be returned by ethtool --show-eee?
The MULT_FACT_100NS value is an internal register setting not meant
to be exposed to userspace, and only relevant when EEE is enabled.
>=20
> --
> RMK's Patch system:
> https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at
> last!