Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1714966pxj; Wed, 19 May 2021 12:10:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6YAWHj4AVtGhFRDwZI9hW8yQe88dpEFleH6915ENCoGPtmep+Xu0CH22sru6n8Rz/dlgm X-Received: by 2002:a05:6602:4c:: with SMTP id z12mr1126759ioz.191.1621451425148; Wed, 19 May 2021 12:10:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621451425; cv=none; d=google.com; s=arc-20160816; b=R0FHbrFr2FUhrGe5VnlHpyjCUq38GfPv7b8zoBYkGUiL78EwJHjo+zxreds6JNSz5x mz2s8N596yTbQY9O/abxPY2ZL2ZA7uoSzcbkZ1GuDd21EjrlKcEyCeA0RU0LtKPFxHI1 a8VXi1F4wyLpOgiAHQpxKGP75p3CS0myOh6LHjVVvsKIi9hj0si5aivkQZTMqJ4CKNjv WrQ8MkYKI6FBhg/M/ITSM+9XgOhrlwnKLgkIHEahSqGgy2XWqKnhpmFBbVq5X69rVlD+ Tw3Ley3+JHWyYXOHarPoKvPq652ZjZU/ZoFA3ZThApBsBit6ZUEfqWXHbCi8EvoFbKBl MIDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D1RKoRUPuNTpnbjdR5aGjDE7LDjBJaTYkeLxTxjV2B0=; b=NCJ7kIh8VOeHptwVw87rCH85tX4z5LF0m41+u2GbLUHRdliZtmc3PacU+3Vulkfxr7 ODyQuvs3Ki5vyzVwQ2WCfoYLNufFA9Pj6imj0Zs3hOyxObvLubB3y/3oP1AGWc+TBA0l cGioNaPOUPp1BqyV/NCnKvZD68E7f4Al88R4yecS3D3eszfle3BmRGYchbx3UlN9DOYS u5D0YCEmljOVoAy85zS8bDAfpResc3qLCpUpHAOb/uUf+NhIue2dJPPKXKxRHMfy//u1 ZI/Vw9V6EiylZw7+XtYp+vzZ+mCHSyDJSVaomctYxARNzCNgHTtRI/FRvOkdA/KQ8Tkp 5sLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XdLYknR3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si168803jak.40.2021.05.19.12.10.10; Wed, 19 May 2021 12:10:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XdLYknR3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353308AbhESERf (ORCPT + 99 others); Wed, 19 May 2021 00:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238882AbhESER2 (ORCPT ); Wed, 19 May 2021 00:17:28 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19397C06175F for ; Tue, 18 May 2021 21:16:08 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id t11so6683994pjm.0 for ; Tue, 18 May 2021 21:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D1RKoRUPuNTpnbjdR5aGjDE7LDjBJaTYkeLxTxjV2B0=; b=XdLYknR3fS24BTVvcLO3iqnPV+utzH9WZmcaLVtD0da3CEd5nRSGOsYgETlrU0h0be XTFcdN16VnEGZSiAQWx8Jvxu/bc14GkHzaqJE4Bu8qqEv0DIneoy8ewj7eTQndwMZPSc gMc5biLXt5doir7/csUoUlJz92NHQKPnwJRvauj5n/4ZF0VmfmQ8D3xND0+36/esjZZ6 QxTtkq8kQ+bqIEwOhilUnMl49r1x2PXqe2KXNzy5JYhS/yzDGtCky1lMghgG9DNIt0Ow 28n2CzKD7dRk6sQKo+KjWubnmO+eTbzcjJoPmVHTmanbu2q1OWqbL0wgMeBB9WVpOnBJ +lgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D1RKoRUPuNTpnbjdR5aGjDE7LDjBJaTYkeLxTxjV2B0=; b=YMJawdV+kcYNHB9yKgIB7VHp4WT4WA7cZm3m1rRO6AtqXtazuzC3+YbSAExNKremUq DrJibILhUjLU8cKScHNk083bfsTCByqFFdYP1o/44lxseQ9YEjXd/uO6o9t/X410lM49 pmbrrdfwDH4lEbrDS6lAtLwEGZ8RB+QAcEdyUR+/MSo3XM2gA2lc4o81DQMSHyJa3vpa SIGsEO0399KNmQiTlvfLCtksh70vyQ8un6eDFNR/V9QUvPoFpDB1znyjgwcFVpDLp0CS 8aw3e0ysIkqq7vyuwjC3v/+wDoa11lCwq78kBOdhSSvNnHVfSPspyk/b4HV43s3vgTkB tCKg== X-Gm-Message-State: AOAM530D38x90fg/6rr+pa424ZuXQJuGw3FZVk9OV/WWdFnctF4CQVij 0ktwatkBr74UpopTrIZ/a2mwIA== X-Received: by 2002:a17:902:f784:b029:ef:8e2f:430e with SMTP id q4-20020a170902f784b02900ef8e2f430emr8615252pln.28.1621397767625; Tue, 18 May 2021 21:16:07 -0700 (PDT) Received: from localhost ([103.207.71.35]) by smtp.gmail.com with ESMTPSA id np1sm3007388pjb.13.2021.05.18.21.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 21:16:07 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Clark , Al Grant , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v2 4/4] perf arm-spe: Remove redundant checking for "full_auxtrace" Date: Wed, 19 May 2021 12:15:46 +0800 Message-Id: <20210519041546.1574961-5-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210519041546.1574961-1-leo.yan@linaro.org> References: <20210519041546.1574961-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The option "opts->full_auxtrace" is checked at the earlier place, if it is false the function will directly bail out. So remove the redundant checking for "opts->full_auxtrace". Suggested-by: James Clark Signed-off-by: Leo Yan --- tools/perf/arch/arm64/util/arm-spe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c index bacdf366040d..a4420d4df503 100644 --- a/tools/perf/arch/arm64/util/arm-spe.c +++ b/tools/perf/arch/arm64/util/arm-spe.c @@ -116,7 +116,7 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, return 0; /* We are in full trace mode but '-m,xyz' wasn't specified */ - if (opts->full_auxtrace && !opts->auxtrace_mmap_pages) { + if (!opts->auxtrace_mmap_pages) { if (privileged) { opts->auxtrace_mmap_pages = MiB(4) / page_size; } else { -- 2.25.1