Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1715095pxj; Wed, 19 May 2021 12:10:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8/VV56SDLM27iEW4fhovY1uG4KIlGC1sabkeLkRROsdZ/B2nW5s3vtjQ8KLPbSwQmX1ep X-Received: by 2002:a50:bec7:: with SMTP id e7mr570662edk.295.1621451434490; Wed, 19 May 2021 12:10:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621451434; cv=none; d=google.com; s=arc-20160816; b=gdVEJ8ztrwr1sv9WtCjCZONv6IC5pWhrkfA1nw33hz9oDi14DYzqHFgJI9HaM7GoA5 Cg7MO7lRUJHHAbru7kbT/Nix1TY4VJeDDkmbd48MTJEcBhsUsyMKwWJ3DHFwMALWHbg9 lquOngYMnj5A6JNbfEwN7ExPt04BLUarcEN2OaJkDdb5fjbQGrCV0v17HShJ5wC+/Kyk nehBy2zN9+AE8bpBCdud8pKy9f2F42NZ4q7Qkeq7nafrVPCDS0dZWJ8GWDKwjiwaCH8l zTLiPYNdZPt3whlrZB62SDXKB88VjBXR8YsmOlUiBQxQ1zdoAAPeA0z7bh3GLDZOd5nH 28xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=mLNrVTCU3JIwEjF1eUnr0SWOGHE1DRob+uSS2pi9KEk=; b=iY+3/xAFN/3Y/Ic9Cd4SNyqnKqUhNlwT0ZkYZSEEzZmeqgWncHny731tYphKM3OD3C /0t1JPRT/B9/98fsPL1r/lHZBbsxlsuo09VZGNw7wooaG2Qzrol3pMt8O6m2QzTqlpkM zX6edKlLqOO9j1z/bugE6NZ20AAJs2vrovztrDZ/0BDc1zrH8V7i6hjEP19RCw4yvXFs MSxtRtn5UkX9boSpLgOldE7Ao/XunxciFnhKvjYMFCZvmi+iwtE50KTiHjmNWZJHdaUT NA7YaLdbrekjN04FuzG1aEmMWCmyCYEhm2Gzzkj/6M7xnIPAY6EwVt+Kak5mgc5YFHTs Oa8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o12si465222eja.417.2021.05.19.12.10.09; Wed, 19 May 2021 12:10:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbhESECA (ORCPT + 99 others); Wed, 19 May 2021 00:02:00 -0400 Received: from mx.socionext.com ([202.248.49.38]:20822 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbhESEB6 (ORCPT ); Wed, 19 May 2021 00:01:58 -0400 Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 19 May 2021 13:00:38 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 64B2620566E0; Wed, 19 May 2021 13:00:38 +0900 (JST) Received: from 172.31.9.53 (172.31.9.53) by m-FILTER with ESMTP; Wed, 19 May 2021 13:00:38 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by iyokan2.css.socionext.com (Postfix) with ESMTP id 21EB5B62A1; Wed, 19 May 2021 13:00:38 +0900 (JST) Received: from [10.212.20.231] (unknown [10.212.20.231]) by yuzu2.css.socionext.com (Postfix) with ESMTP id 5F180B62BA; Wed, 19 May 2021 13:00:37 +0900 (JST) Subject: Re: [PATCH v11 0/3] PCI: uniphier: Add PME/AER support for UniPhier PCIe host controller To: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Marc Zyngier Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jassi Brar , Masami Hiramatsu References: <1619111097-10232-1-git-send-email-hayashi.kunihiko@socionext.com> From: Kunihiko Hayashi Message-ID: Date: Wed, 19 May 2021 13:00:37 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1619111097-10232-1-git-send-email-hayashi.kunihiko@socionext.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gentle Ping. Are there any comments about this series? Thank you, On 2021/04/23 2:04, Kunihiko Hayashi wrote: > This adds a new function called by MSI handler in DesignWare PCIe framework, > that invokes PME and AER funcions to detect the factor from SoC-dependent > registers. > > Changes since v10: > - Fix comment style in the header > - Fix "virq" and "vIRQ" in variable name and description to "irq" and "IRQ" > > Changes since v9: > - Fix the description of pcie_prot_service_get_irq() > > Changes since v8: > - Add uniphier_pcie_host_init_complete() that finds PME/AER IRQ number > after calling dw_pcie_host_init() > - Add conditions to depend on CONFIG_PCIE_PME and CONFIG_PCIEAER instead > of CONFIG_PCIEPORTBUS > - Add Acked-by: line to portdrv patch > > Changes since v7: > - Add Reviewed-by: line to 1st and 3rd patches > > Changes since v6: > - Separate patches for iATU and phy error from this series > - Add Reviewed-by: line to dwc patch > > Changes since v5: > - Add pcie_port_service_get_irq() function to pcie/portdrv > - Call pcie_port_service_get_irq() to get IRQ interrupt number for PME/AER > - Rebase to the latest linux-next branch, > and remove devm_platform_ioremap_resource_byname() replacement patch > > Changes since v4: > - Add Acked-by: line to dwc patch > > Changes since v3: > - Move msi_host_isr() call into dw_handle_msi_irq() > - Move uniphier_pcie_misc_isr() call into the guard of chained_irq > - Use a bool argument is_msi instead of pci_msi_enabled() > - Consolidate handler calls for the same interrupt > - Fix typos in commit messages > > Changes since v2: > - Avoid printing phy error message in case of EPROBE_DEFER > - Fix iATU register mapping method > - dt-bindings: Add Acked-by: line > - Fix typos in commit messages > - Use devm_platform_ioremap_resource_byname() > > Changes since v1: > - Add check if struct resource is NULL > - Fix warning in the type of dev_err() argument > > Kunihiko Hayashi (3): > PCI: portdrv: Add pcie_port_service_get_irq() function > PCI: dwc: Add msi_host_isr() callback > PCI: uniphier: Add misc interrupt handler to invoke PME and AER > > drivers/pci/controller/dwc/pcie-designware-host.c | 3 + > drivers/pci/controller/dwc/pcie-designware.h | 1 + > drivers/pci/controller/dwc/pcie-uniphier.c | 105 +++++++++++++++++++--- > drivers/pci/pcie/portdrv.h | 1 + > drivers/pci/pcie/portdrv_core.c | 16 ++++ > 5 files changed, 112 insertions(+), 14 deletions(-) > -- --- Best Regards Kunihiko Hayashi