Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1717487pxj; Wed, 19 May 2021 12:13:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywPMXtMIDQnO/7EZRyp+hMWzBESu+dWeuFcpOPLDF615bxsTs5115K1FOIVuheRm4bslWf X-Received: by 2002:a05:6402:1158:: with SMTP id g24mr621941edw.134.1621451618450; Wed, 19 May 2021 12:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621451618; cv=none; d=google.com; s=arc-20160816; b=n1LQrvtHG448Qmg4gLAvaQUu2xP1lD1LbcaVi5iBlTaJdB4Birqj+8RXifvrDgsIUN NJcEzbw8n15riYji4dSoiwg9pol/yPk+zH00Jk4ERFrok2XohtQAHDsXD+l5VSD26REb KnFDsNYYZobHB6PymFdllizGBxuO8tpr0UzSWqpkV9CvLMTOgsotrqZtpcRdGhY7QzwM bNTReHxW0txoJ1onN/qgSrERqC2T5IcdvKrnqorqa5tJVMOU2yRQFZfJdCXIiEsXmxii LildxHdqhpVJTIHMFXLy5SF83GtRE7kaYplA/kFb/TbGv7ayerg2F9qosSNPViOoMsjD Thog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BvCMRttPf/TJqIxdmSUmQm/huvf1KSvWFJ4QU8dhZnk=; b=ZVG0JbGR5s5Y0wCsZQK9rRyAM7DY5FrFz1Cui89cGgHjCukVycYpWJmDe82o7/zOTn WJ4+rRHni9cT15/Fq/cDJmJdhA+oOXMejXUfrTzfGro/ty/0eDbsESmEkFkQmVKSiQ4P vrtl+Nx7H7ovyp7VFHXSA0WpgncfhTAws8dzE8wZ3+ALITAhFRjIOPy4oQPuD812tDou 1DQCru9XRN0Yn846iDuSCDNDw34nmFQce95AbYDO1JbTmiDEP5AbLxzWuhfRWEFvMHVa BpPfQRg4HBWgetFeJfnRT77wOtESSWdihyUR9yu7AeYcLFWjl4k8Iojo2uadIuILkeDZ Zklg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=CV3ss4X4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 17si108944edv.148.2021.05.19.12.13.12; Wed, 19 May 2021 12:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=CV3ss4X4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242712AbhESFhW (ORCPT + 99 others); Wed, 19 May 2021 01:37:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240379AbhESFft (ORCPT ); Wed, 19 May 2021 01:35:49 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C4AEC061344 for ; Tue, 18 May 2021 22:34:27 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id v13so6358648ple.9 for ; Tue, 18 May 2021 22:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BvCMRttPf/TJqIxdmSUmQm/huvf1KSvWFJ4QU8dhZnk=; b=CV3ss4X4zAfCIAxywB9c5q8IlVUT1MajJkdkgC6I1ntnX9+2t276blstc5JZXkrArs yG6PXbxxCaQ0iHrRO2CTgoomX4v1YH1TnxgirKjmSoB7LwA38t8GXd0yxCpGO+jhizJY PCF7+9P80QUYBMoNxT667Bq5uW5JSS98qs6K+3tU79MJ7ztOWwNCN1aL3lBTvIxK8BRi dFSxrAvLrdEYdHAsJTz4u1zb1PKZXrbXOPwhtXvEdHbVYsqHgiMf1tfFpDKsdjwxFi9U U0rHSGwE7UjiFSnHUbE2LatX+hxDXvouahNkVFQCUdb8bE6cOGB45YagFvOLcXi2IFbm oULA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BvCMRttPf/TJqIxdmSUmQm/huvf1KSvWFJ4QU8dhZnk=; b=EI9VEMiPl/vWlypSx6UtKS5S9aS3TpEMZtH53nPzLWI7CNeTbHh26HsEBN5VpJezpQ E1Jv7X0ioy63wPJRk+Bi9akSbwHFD78hcNtDPNQQVxiVKKk2myEj+OfwCkTqskTGfS6h Hmly0x89Nrk8yEE9Kz0m2d/beAdsLdOrWDpO2FeridsiOm+cc40BtcdpafouAWMa+TtF pV6RBbuubBd38QzUcPl0lMk55c3c5OSIN4A4orCHfhWCctIsSAz14Ld6sMw32RAbjLFh AIgWaDI6M4JU0D6EjtUzk1deoUy3W0NtaN/a85oCrIElhPV4AUwPSFH9DKvz1x+qTdOr PO9A== X-Gm-Message-State: AOAM532LVnQJfQE5k/CM9CGmJI416EdlQ4orBMf5T2n8VUucS37vuv8V M+fTSuvfTY2SkBkGnfCJD7Vk74DHAmzs/85OYL7Iig== X-Received: by 2002:a17:90a:6f06:: with SMTP id d6mr9677207pjk.216.1621402466801; Tue, 18 May 2021 22:34:26 -0700 (PDT) MIME-Version: 1.0 References: <20210424004645.3950558-1-seanjc@google.com> <20210424004645.3950558-21-seanjc@google.com> In-Reply-To: <20210424004645.3950558-21-seanjc@google.com> From: Reiji Watanabe Date: Tue, 18 May 2021 22:34:11 -0700 Message-ID: Subject: Re: [PATCH 20/43] KVM: SVM: Don't bother writing vmcb->save.rip at vCPU RESET/INIT To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 5:51 PM Sean Christopherson wrote: > > Remove unnecessary initialization of vmcb->save.rip during vCPU RESET/INIT, > as svm_vcpu_run() unconditionally propagates VCPU_REGS_RIP to save.rip. > > No true functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Reiji Watanabe