Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1723647pxj; Wed, 19 May 2021 12:21:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNz6aj/pSQerye1qHQP8yvYqsqXfb2lkdkPHz0Yh1G+07vRJwxSOMHBqCgyA8rmhGWh7x9 X-Received: by 2002:a17:906:b0d:: with SMTP id u13mr672937ejg.159.1621452113918; Wed, 19 May 2021 12:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621452113; cv=none; d=google.com; s=arc-20160816; b=LY6N90/zRH8EN//R+S3YDK4RMIsWGl8ix3O/53L06lhEjTKc7mSazQ9UM3qRnj076t UKTJdEIXJSJlh2hWe/E28f1O2WKnWU3SBJ//c1WcaILwbXjdzJoYgdf0HaxYM79bdMQ9 FoYO2yPQMAHUAwyM5rXNoqVhxFpDnOzjAcBHww2UAsrPJSU+7SJsm/C2YEBBsOQjQjSn D2/6Me7GtgmtevA1xjMqyiOSUWwvklfzjsFXR/LtmIAapdv2In2NUlPOXfrMXwNvUYY5 YGLZ3LXpAurQXrMMyoqGfDtKZzVyD9Wtc+ZhAqu/+wJPy/YfO4jqWkN6778PGjNV84Me lHig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=dupVC/XNXY322g+ifG9Gc14WgZcad7WmYeFmZkisbek=; b=hDqs2zS0RCd/bbNS+iiKHY16t9ny62PD+p0BItLLfWevNFsZNzE+KzJDQJl6RYylWL NhbtWFf7it97oIY8hlHBjr3XMFycG6Qk0kuTdwWPkQ0hmmmhBgsWtyxgv5UeQ1M8/pq3 dLYbnS6inWUTBXZHgJqqnsGLyBLwcDr3IJWGHK+r0FWs1eNVOI0GllaiaEHkcor0mWc7 iMbl6Xee+r1XOBpVnHd9OGUO1HxnHK+nYOxGBZLcX0a4ilMkAlygtUncA+oCSqtHXzPn MehN9BnaTsnL1rxW853caIPiLWphJt5PDL4pUbCH92MYDJkqD6VH5ATC7LvRo5UX5K0b OAVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w3si91786edt.165.2021.05.19.12.21.29; Wed, 19 May 2021 12:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236151AbhESIId (ORCPT + 99 others); Wed, 19 May 2021 04:08:33 -0400 Received: from mga01.intel.com ([192.55.52.88]:28069 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235683AbhESIIb (ORCPT ); Wed, 19 May 2021 04:08:31 -0400 IronPort-SDR: COl2Nu6Dd9AE5Ne0QP0ESgfVUGHUOc3b2+3RPAqqw7Uk6rNIvfy0+lVz59tG4PeK5xcFkcocqi zK915tXQNlTw== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="221984080" X-IronPort-AV: E=Sophos;i="5.82,312,1613462400"; d="scan'208";a="221984080" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 01:07:12 -0700 IronPort-SDR: +m6QThSTl14NxX0mj/VRdu4CnV61XHCXHOpwQDCABkD55XFK7ns2/d36Ij8WIWZh2o4cI7wOQs 2TGdrPwoRnXg== X-IronPort-AV: E=Sophos;i="5.82,312,1613462400"; d="scan'208";a="627525656" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 01:07:08 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1ljHEO-00DAfC-Ef; Wed, 19 May 2021 11:07:04 +0300 Date: Wed, 19 May 2021 11:07:04 +0300 From: Andy Shevchenko To: Al Viro Cc: Linus Torvalds , Jia He , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "Eric W . Biederman" , "Darrick J. Wong" , "Peter Zijlstra (Intel)" , Ira Weiny , Eric Biggers , "Ahmed S. Darwish" , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-s390 , linux-fsdevel Subject: Re: [PATCH 12/14] d_path: prepend_path(): lift the inner loop into a new helper Message-ID: References: <20210519004901.3829541-1-viro@zeniv.linux.org.uk> <20210519004901.3829541-12-viro@zeniv.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519004901.3829541-12-viro@zeniv.linux.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 12:48:59AM +0000, Al Viro wrote: > ... and leave the rename_lock/mount_lock handling in prepend_path() > itself ... > + if (!IS_ERR_OR_NULL(mnt_ns) && !is_anon_ns(mnt_ns)) > + return 1; // absolute root > + else > + return 2; // detached or not attached yet Would it be slightly better to read if (IS_ERR_OR_NULL(mnt_ns) || is_anon_ns(mnt_ns)) return 2; // detached or not attached yet else return 1; // absolute root ? Oh, I have noticed that it's in the original piece of code (perhaps separate change if we ever need it?). -- With Best Regards, Andy Shevchenko