Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   John Ogness <john.ogness@linutronix.de>
To:     Ruifeng Zhang <ruifeng.zhang0110@gmail.com>, pmladek@suse.com,
        senozhatsky@chromium.org, rostedt@goodmis.org
Cc:     linux-kernel@vger.kernel.org, ruifeng.zhang1@unisoc.com,
        nianfu.bai@unisoc.com, orson.zhai@unisoc.com
Subject: Re: [PATCH v1 1/1] printk: always output coreid in caller information
In-Reply-To: <20210519063355.5147-1-ruifeng.zhang0110@gmail.com>
References: <20210519063355.5147-1-ruifeng.zhang0110@gmail.com>
Date:   Wed, 19 May 2021 10:25:32 +0200
Message-ID: <87v97ft9j7.fsf@jogness.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hello Ruifeng,

On 2021-05-19, Ruifeng Zhang <ruifeng.zhang0110@gmail.com> wrote:
> From: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
>
> Sometimes we want to know which cpu the process is running
> on when the log output, rather than the thread id.  So add
> the processor id output always in the caller information.
>
> caller_id bitmap:
> [63:32] thread_id
> [31]    flags of in thread context
> [30:0]  processor id

The primary purpose of @caller_id is so that the printk-subsystem can
coordinate LOG_CONT messages.

Your patch is about logging/printing additional context attributes of
the printk-caller. This is something we have discussed before [0]. I
think this should be addressed at some point. But we need to come up
with a solution that is flexible and generic. We should not be touching
these core structures every time some new attribute needs to be printed.

Also, this patch is controversial for other reasons:

- it adds bitwise logic, when it could more easily just add a new field
  (for example, caller_cpu)

- it increases the size of all records by 4 bytes

- it changes the internal structure in a way that breaks existing crash
  tools

- for non-task contexts, the increased size is wasted

John Ogness

[0] https://lore.kernel.org/lkml/20200904082438.20707-1-changki.kim@samsung.com