Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [bug report] Memory leak from acpi_ev_install_space_handler()
To:     "Kaneda, Erik" <erik.kaneda@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
CC:     ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        chenxiang <chenxiang66@hisilicon.com>
References: <845f6ef8-d2a7-e491-8405-9526e4ba277a@huawei.com>
 <CAJZ5v0gRm+jsd1KtLtSgT=4pc9oab=EtW=zqBuKjHLJ=ZcUkiA@mail.gmail.com>
 <752f16ed-29e3-840e-dc53-6fed24d73861@huawei.com>
 <MWHPR11MB1599342DCB12AEA5B7DD0D54F02C9@MWHPR11MB1599.namprd11.prod.outlook.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <3ab18796-f8b5-9498-a31a-5dfd21059ebb@huawei.com>
Date:   Wed, 19 May 2021 09:20:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <MWHPR11MB1599342DCB12AEA5B7DD0D54F02C9@MWHPR11MB1599.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/05/2021 22:48, Kaneda, Erik wrote:
> Hi John,
> 
>> I don't mind looking further if requested.
> Someone else reported this as well. 

I noticed. By chance, it was my close colleague Xiang Chen.

Could you try the patch below? I think it might help fix this issue..

It looks like the same problem, and you provided the same solution, so 
we can look to test it.

Thanks

> 
> Thanks,
> Erik
> 
> diff --git a/drivers/acpi/acpica/utdelete.c b/drivers/acpi/acpica/utdelete.c
> index 624a26794d55..e5ba9795ec69 100644
> --- a/drivers/acpi/acpica/utdelete.c
> +++ b/drivers/acpi/acpica/utdelete.c
> @@ -285,6 +285,14 @@ static void acpi_ut_delete_internal_obj(union acpi_operand_object *object)
>                  }
>                  break;
> 
> +       case ACPI_TYPE_LOCAL_ADDRESS_HANDLER:
> +
> +               ACPI_DEBUG_PRINT((ACPI_DB_ALLOCATIONS,
> +                                 "***** Address handler %p\n", object));
> +
> +               acpi_os_delete_mutex(object->address_space.context_mutex);
> +               break;
> +
>          default:
> 
>                  break;
>