Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1726290pxj; Wed, 19 May 2021 12:25:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUHRzCgIDzbLwcycdueEXENTxg31HjFvfWpTnK1nyoAv7bYt9Kh4k3M5XJyGcD1o7I9aRS X-Received: by 2002:a6b:3b92:: with SMTP id i140mr1157970ioa.23.1621452329718; Wed, 19 May 2021 12:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621452329; cv=none; d=google.com; s=arc-20160816; b=Dyinfktej5kEraz8bZh/nZZX1GjdXR+pXzuU/3txihb5nQkJLeCfZiJeSEmrw1nNvD paEwNAoYppgl3Qbyr9hOzRHd0FkvTm1kEVs+L4tPUb6qLPa5LpDKUiZRqIxdaNijWLrl 1XlaGAgdCij+Bdxy/1jcoIFw0PO6cX4p+EQE1zjlXrG9m1Dgi1Db3MBQ5WE6+ebtl0k/ YFrWG2T9rwDVJijnxZOCPwpYydhrhS338J8GDuFjsxw93+S9Yfcm4oVb+lbS2fIMVKTr 0l0WQGCich4fw1iNyqPfJ+0C6LA3z+dNiyK8tEv5AHTI2LP8f+T6TzFjV6hqf6ILHp1/ fWAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HLRBruChIxJSC0wNSw2yXex349luL3KIekiNUDyMO1g=; b=HSInniSdJGeAnQN8vl57jjEAROEdz+80jy9E97AOTY/zXbtvSr3EXYgPkeP8A3FQ7p n40wrSNDakesuiOqrqvY3p+H3sMu/HhuD4ZmlmbssZB3qVVzfUlcQ4mF19LoNs2UCChP e95DHxmCoEMdehL6ZKkt8cBm+tEEkB8Lh4YDwRVkwkvH1+zReHWLjbWroaZ9kh7glQP0 D5Ad8GaGex1hX3lqQdTdFzSartYUNyfD9CldWVcB+fBRKOWFTY1zcb2crgSmzw29DEvj sEhjqcXHW8ck11LDvL0X+u2KhcNEwpUfAW3w23DwR9XlZnQ3zfkzMk6podqKZCFULeqb xvrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ODb6tP/t"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 19si566249ilg.27.2021.05.19.12.25.17; Wed, 19 May 2021 12:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ODb6tP/t"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345740AbhESJe6 (ORCPT + 99 others); Wed, 19 May 2021 05:34:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:51608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345520AbhESJek (ORCPT ); Wed, 19 May 2021 05:34:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9195F613AC; Wed, 19 May 2021 09:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621416801; bh=+z50DH6y5nk22AVu8oFQ8KsCNGoWbe85hVbd+LyXB+0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ODb6tP/t7Jvc+menfbfq/p4DYqo40r51CsJNcBJ69RnTNqxtwCwCwuJyjR9wi8oJG qW70w+CllhxvyE4HAIY2eXjfKQO+0KN+cxA+Xh/rxzmsOF5gZfaVvsq31tbrdu/8rC 37J/CkLHboPMawkf9I9yizwweaoWcW8tprgecgJtY5V61tRjQjozCNvgg7oICevox5 7vTfiHW75cZDYMu1NJ31M1YGvpXn6NHh6tm3/oPjbjC+SJZsmf3mXLSmJMVvMyoU3K 6njG3XPkZqV2aF1XenkxkQ0REyEh69TxH2SB75jYdwQCG+DdaCqVaF8r1oTA7I7GVT 6UGHuxJYpT4zw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ljIZt-0002pU-0t; Wed, 19 May 2021 11:33:21 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Minas Harutyunyan Subject: [PATCH 2/3] USB: dwc2: drop irq-flags initialisations Date: Wed, 19 May 2021 11:33:02 +0200 Message-Id: <20210519093303.10789-3-johan@kernel.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210519093303.10789-1-johan@kernel.org> References: <20210519093303.10789-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no need to initialise irq-flags variables before saving the interrupt state. While at it drop two redundant return-value initialisations from two of the functions that got it wrong. Cc: Minas Harutyunyan Signed-off-by: Johan Hovold --- drivers/usb/dwc2/gadget.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 184964174dc0..b16fb3611a86 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -1496,8 +1496,8 @@ static int dwc2_hsotg_ep_queue_lock(struct usb_ep *ep, struct usb_request *req, { struct dwc2_hsotg_ep *hs_ep = our_ep(ep); struct dwc2_hsotg *hs = hs_ep->parent; - unsigned long flags = 0; - int ret = 0; + unsigned long flags; + int ret; spin_lock_irqsave(&hs->lock, flags); ret = dwc2_hsotg_ep_queue(ep, req, gfp_flags); @@ -4374,8 +4374,8 @@ static int dwc2_hsotg_ep_sethalt_lock(struct usb_ep *ep, int value) { struct dwc2_hsotg_ep *hs_ep = our_ep(ep); struct dwc2_hsotg *hs = hs_ep->parent; - unsigned long flags = 0; - int ret = 0; + unsigned long flags; + int ret; spin_lock_irqsave(&hs->lock, flags); ret = dwc2_hsotg_ep_sethalt(ep, value, false); @@ -4505,7 +4505,7 @@ static int dwc2_hsotg_udc_start(struct usb_gadget *gadget, static int dwc2_hsotg_udc_stop(struct usb_gadget *gadget) { struct dwc2_hsotg *hsotg = to_hsotg(gadget); - unsigned long flags = 0; + unsigned long flags; int ep; if (!hsotg) @@ -4577,7 +4577,7 @@ static int dwc2_hsotg_set_selfpowered(struct usb_gadget *gadget, static int dwc2_hsotg_pullup(struct usb_gadget *gadget, int is_on) { struct dwc2_hsotg *hsotg = to_hsotg(gadget); - unsigned long flags = 0; + unsigned long flags; dev_dbg(hsotg->dev, "%s: is_on: %d op_state: %d\n", __func__, is_on, hsotg->op_state); -- 2.26.3