Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1727063pxj; Wed, 19 May 2021 12:26:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+l1bBN07nq5rXyiQPwaRRO3agvv4Xl7F/Rc9K21s8KpmepXSiuzFpPnFN5hU16CuCUkbH X-Received: by 2002:aa7:d598:: with SMTP id r24mr679642edq.250.1621452389128; Wed, 19 May 2021 12:26:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621452389; cv=none; d=google.com; s=arc-20160816; b=TDQaFdJO8ci3b1XF3mz1lQJUlTZ7u6KUUxp4RB/AWct/IQ4SYMG4/rQ2X6G7dkK7ID 8mrYi8i6REJ/qLGOPH0PxopfocGTzDp2Z3WKCFGcRupXxtYR6Nl7LqanUQSGKjLvEbSa 8qYDg1SAi64LP3RMHX86d4QYF4IpwSly/21QcHzjUGSuwNUxDURwsnKdt0Der36AoWbx PqhV9Tg0DghEWjeBvyCZ0pRggVvMRelulCcdjItuhgT9Wa0lR9Hcp4qnS20vt3Eyi5GR dxGdgfAbgemxZ/ekeQ8dphLAQ8WIfrVnCavwZgbGfjei4jpiwGMKiCk65sD8amuevAac Zpfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=4X3muKIzO6SON87shWo+JuqBEimNtVlbB0d1KXyWJ90=; b=HrVsRQWgI4CHIG4rJmzW/VvKqan/iVusH7qoi7U89vKE6vL2KBvPAn4KN2DMvngA97 h+x3nbG9sCz93IiDVrm4IrAF4F2oWXr+oOVEvHAi+NeqXfYftsEXC/VOoMHOIgq2nOQd ua3qIj3wxhg4o/0o/+oReRHi3XLYY2F+6zNOxplhw1ha04Gjy5wlZH8K5sD3BkIsM5BE ew50m2KVdiR4J/aVxlnziESIn0bJf+VdrekZn5R+cda1hWyzd8aBzCVRVl8y545Rx6Wk fvnXBHZcrT15YqFETK5WFycHuP/R75IDn853mB+J4crgNoDCjBiuAm3yCdchS+eTQ7CU tGlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si304692ejk.397.2021.05.19.12.26.04; Wed, 19 May 2021 12:26:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345097AbhESJpb (ORCPT + 99 others); Wed, 19 May 2021 05:45:31 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3028 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239386AbhESJpa (ORCPT ); Wed, 19 May 2021 05:45:30 -0400 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FlSXm3SfrzQpfn; Wed, 19 May 2021 17:40:40 +0800 (CST) Received: from dggema765-chm.china.huawei.com (10.1.198.207) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 19 May 2021 17:44:10 +0800 Received: from DESKTOP-6NKE0BC.china.huawei.com (10.174.185.210) by dggema765-chm.china.huawei.com (10.1.198.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 19 May 2021 17:44:10 +0800 From: Kunkun Jiang To: Will Deacon , Robin Murphy , "Eric Auger" , "moderated list:ARM SMMU DRIVERS" , "open list:IOMMU DRIVERS" , open list CC: , Keqian Zhu , "Zenghui Yu" , Kunkun Jiang Subject: [RFC PATCH v1 0/2] iommu/arm-smmu-v3: Add some parameter check in __arm_smmu_tlb_inv_range() Date: Wed, 19 May 2021 17:43:05 +0800 Message-ID: <20210519094307.3275-1-jiangkunkun@huawei.com> X-Mailer: git-send-email 2.26.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.174.185.210] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggema765-chm.china.huawei.com (10.1.198.207) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, This set of patches solves some errors when I tested the SMMU nested mode. Test scenario description: guest kernel: 4KB translation granule host kernel: 16KB translation granule errors: 1. encountered an endless loop in __arm_smmu_tlb_inv_range because num_pages is 0 2. encountered CERROR_ILL because the fields of TLB invalidation command are as follow: TG = 2, NUM = 0, SCALE = 0, TTL = 0. The combination is exactly the kind of reserved combination pointed out in the SMMUv3 spec(page 143-144, version D.a) In my opinion, it is more appropriate to add parameter check in __arm_smmu_tlb_inv_range(), although these problems only appeared when I tested the SMMU nested mode. What do you think? This series include patches as below: Patch 1: - align the invalid range with leaf page size upwards when smmu supports RIL Patch 2: - add a check to standardize granule size when smmu supports RIL Kunkun Jiang (2): iommu/arm-smmu-v3: Align invalid range with leaf page size upwards when support RIL iommu/arm-smmu-v3: Standardize granule size when support RIL drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.23.0