Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 12:09:15 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To:     Marek Behun <marek.behun@nic.cz>
Cc:     linuxarm@huawei.com, mauro.chehab@huawei.com,
        Pavel Machek <pavel@ucw.cz>, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 10/17] leds: leds-nuc: Add support to blink behavior
 for NUC8/10
Message-ID: <20210519120915.40b4da10@coco.lan>
In-Reply-To: <20210519095843.2fa66bf8@thinkpad>
References: <cover.1621349813.git.mchehab+huawei@kernel.org>
        <f300479684e61d3aaa3790753851217f13a4821a.1621349814.git.mchehab+huawei@kernel.org>
        <20210519095843.2fa66bf8@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Em Wed, 19 May 2021 09:58:50 +0200
Marek Behun <marek.behun@nic.cz> escreveu:

> This should be implemented via the blink trigger or hw_pattern, I think.
> Have you looked at these?

The blink trigger and hw_pattern are software implementations for blink.

This is not the case on NUC leds, as:

1. It is the hardware/firmware that triggers the blink, not Linux;
2. It blinks even when Linux in suspend/hibernate mode.

In a matter of fact, the default usage of blink is to indicate that the
machine is suspended.

Thanks,
Mauro