Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1727527pxj; Wed, 19 May 2021 12:27:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnjELz+6EtvNxERwW76JT/mUIexPVnoME8JnXL7YfW2wUKOWD7yJ68R0M1suiKKOMhqP2i X-Received: by 2002:a92:d48e:: with SMTP id p14mr600713ilg.33.1621452422792; Wed, 19 May 2021 12:27:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621452422; cv=none; d=google.com; s=arc-20160816; b=PB/sO2zUYZgcK5ucevdZpBeD4tLlzAJrwfR7kkMEZnzSABUxOGwES/3BRFRBn00DAd Hql+3SJzJX6Idh016F0h6/ZNGDmLrmZOLHD8tbOyEDlh2qQE0dmA/AHUtnZs9B0aqUEW Mr1Sr+KmylU/yrpCkZ9aZel6ZgVEiXHfXdym3e4262TakYdbLL1+T3zYFnKPNL41Otpc NqiHYQZTCY7XT4mFEn70HDONKfxAVHmunxUvUPcYcawnB7Td3154Z0K2TXlutAipmpvO wo1GKSiFczk3PnKhLtaVfzYWHNG9NUNjXJzWlx8H39RSsdOzeaDzMw/3pqaB9+r/UO9J awQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=yX4qRlozetOB5yj4uqZael68BwO20FwdPx1Y7be/0Bw=; b=s+YtzQyC85qXDCyviXq2/dlCZ247zszR43U2ibDvTHXWKOemfs+koc2I5XlUJWZ4xX UQBwvq6hQ7QE8fRAxsZD63C15dVujiAhT492Jd0yKo5mh+PRZzW+HNiu85CnR2kof5xi RTuoeRXqWe+b+WIkccvmkOsNbTLCAtn3pUznvDHKs5v40qJPC9Kr9bZrDe57Or8PFpiO 0uyIFP9p4DLVrMcBvETXv+fZjHiYajz/qeyISr7i7mnO5isj4U2M41EfSQ1CgPjrFL9w ct08Zc/S0aIkDq8ZSnHQoKQkm6lCCQYXUtF2t/gFYAl5qPWluxHAZEKWnAcW7wWtCAlr f6+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y196si205603iof.24.2021.05.19.12.26.49; Wed, 19 May 2021 12:27:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347800AbhESKT3 (ORCPT + 99 others); Wed, 19 May 2021 06:19:29 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:49285 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232933AbhESKT0 (ORCPT ); Wed, 19 May 2021 06:19:26 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R341e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0UZOs6SD_1621419484; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UZOs6SD_1621419484) by smtp.aliyun-inc.com(127.0.0.1); Wed, 19 May 2021 18:18:05 +0800 From: Yang Li To: rmk+kernel@armlinux.org.uk Cc: linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] fs/adfs: bigdir: Fix an error code in adfs_fplus_read() Date: Wed, 19 May 2021 18:18:03 +0800 Message-Id: <1621419483-9339-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This code accidentally returns 0, but it should return the -EIO error code to show a I/O error. Clean up smatch warning: fs/adfs/dir_fplus.c:146 adfs_fplus_read() warn: missing error code 'ret' Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/adfs/dir_fplus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/adfs/dir_fplus.c b/fs/adfs/dir_fplus.c index 4a15924..4334279 100644 --- a/fs/adfs/dir_fplus.c +++ b/fs/adfs/dir_fplus.c @@ -143,6 +143,7 @@ static int adfs_fplus_read(struct super_block *sb, u32 indaddr, if (adfs_fplus_checkbyte(dir) != t->bigdircheckbyte) { adfs_error(sb, "dir %06x checkbyte mismatch\n", indaddr); + ret = -EIO; goto out; } -- 1.8.3.1