Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1727844pxj; Wed, 19 May 2021 12:27:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyV4R+iGj4nJQFgiFFzIsPJg7XF6Cao7jahhHlYQW2OWJuy0bPFW1t0mwByPpDRuxqA6NSB X-Received: by 2002:a02:ac05:: with SMTP id a5mr730421jao.89.1621452454224; Wed, 19 May 2021 12:27:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621452454; cv=none; d=google.com; s=arc-20160816; b=S8bTqd356sIqIy+gKM6YBhnkGKMeHzQ9RjiT6JSPsM9nwGgCLAI6wbOQitEseqAODR VCYAqH4ajt0g9/+waCmPaLP36yJfcPZVMcoj/yobfurVyU76jVo71WBWIt6qQvAU9HKT jfxmHxnSLsueYzlFsFaNaD/g/delmm0DrZn/Ue7nDxRwsH3fnn06SRX6wsr5KqoP89LM GrKYX3VkF8yYb3fKJdoDsiqf2FJdBskBr36AsYSPcWXL0RSNMDFxBMF5xKuG67yN1Hdo PtumxMjefRH6TozG1mug+1LY0w2+hLt2lfz7VniBRJ/IhGrpUvlAcMU2bUSyB+UaX4As rjzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=YErLfu0YE6QlQLJnc2Lf0lIQQYF0EmAM2VxsDX+vC/Y=; b=HjD5F0NVfEj41DIRoEwXEArn/KeijojyC5weYXj1+lfNdiqGNpFwkiaaqTgN1Nu4Q2 q6kL97aXER3ebt9XBHzPTqKnykJCQzDH1z9NoaZ4va+0J/gFVnemREJcn3vrK8lOo28u f7yLYBax97kQfR9l7HIkIgRZ2aOzd7yR7kXSbG3uMZK0qi/czPM/mo20rsYaZdXMknlU SkwqdsUSgLdJ9KJ8wrS0AYOKIyVapwCe3lAQVNNDRXyJyXxhDcXRMMIg/NEjqmgsN851 ZUakUmpabLkNEeoSfY9vlvuhfmQol9b84DywlppYGP1sAibc3QnwyfpdGaVuqdMSAMcU EIPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si29843jas.31.2021.05.19.12.27.21; Wed, 19 May 2021 12:27:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348948AbhESKny (ORCPT + 99 others); Wed, 19 May 2021 06:43:54 -0400 Received: from foss.arm.com ([217.140.110.172]:58980 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348574AbhESKno (ORCPT ); Wed, 19 May 2021 06:43:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B80451424; Wed, 19 May 2021 03:42:24 -0700 (PDT) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 460703F719; Wed, 19 May 2021 03:42:22 -0700 (PDT) From: Andre Przywara To: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec Cc: Rob Herring , Icenowy Zheng , Samuel Holland , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Subject: [PATCH v6 07/17] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register Date: Wed, 19 May 2021 11:41:42 +0100 Message-Id: <20210519104152.21119-8-andre.przywara@arm.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20210519104152.21119-1-andre.przywara@arm.com> References: <20210519104152.21119-1-andre.przywara@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Allwinner H616 SoC has two EMAC controllers, with the second one being tied to the internal PHY, but also using a separate EMAC clock register. To tell the driver about which clock register to use, we add a parameter to our syscon phandle. The driver will use this value as an index into the regmap, so that we can address more than the first register, if needed. Signed-off-by: Andre Przywara --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 4422baeed3d8..5f3fefd9a74e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -1147,11 +1147,13 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) struct stmmac_resources stmmac_res; struct sunxi_priv_data *gmac; struct device *dev = &pdev->dev; + struct reg_field syscon_field; phy_interface_t interface; int ret; struct stmmac_priv *priv; struct net_device *ndev; struct regmap *regmap; + u32 syscon_idx = 0; ret = stmmac_get_platform_resources(pdev, &stmmac_res); if (ret) @@ -1209,8 +1211,12 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) return ret; } - gmac->regmap_field = devm_regmap_field_alloc(dev, regmap, - *gmac->variant->syscon_field); + syscon_field = *gmac->variant->syscon_field; + ret = of_property_read_u32_index(pdev->dev.of_node, "syscon", 1, + &syscon_idx); + if (!ret) + syscon_field.reg += syscon_idx * sizeof(u32); + gmac->regmap_field = devm_regmap_field_alloc(dev, regmap, syscon_field); if (IS_ERR(gmac->regmap_field)) { ret = PTR_ERR(gmac->regmap_field); dev_err(dev, "Unable to map syscon register: %d\n", ret); @@ -1330,6 +1336,8 @@ static const struct of_device_id sun8i_dwmac_match[] = { .data = &emac_variant_a64 }, { .compatible = "allwinner,sun50i-h6-emac", .data = &emac_variant_h6 }, + { .compatible = "allwinner,sun50i-h616-emac", + .data = &emac_variant_h6 }, { } }; MODULE_DEVICE_TABLE(of, sun8i_dwmac_match); -- 2.17.5