Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 12:00:32 +0100
From:   Jonathan McDowell <noodles@earth.li>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Ansuel Smith <ansuelsmth@gmail.com>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: qcom: Add tsens details to ipq806x
Message-ID: <20210519110032.GQ11733@earth.li>
References: <cover.1621097174.git.noodles@earth.li>
 <cbcac8439d3fcaaf17df041cab12d904c8058189.1621097174.git.noodles@earth.li>
 <YKI6amMC8Rg6Kb1I@vkoul-mobl.Dlink>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YKI6amMC8Rg6Kb1I@vkoul-mobl.Dlink>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, May 17, 2021 at 03:12:02PM +0530, Vinod Koul wrote:
> On 15-05-21, 17:52, Jonathan McDowell wrote:
> 
> >  		gcc: clock-controller@900000 {
> > -			compatible = "qcom,gcc-ipq8064";
> > +			compatible = "qcom,gcc-ipq8064", "syscon";
> 
> Does this belong here

No, not sure how that slipped in, will remove for v2.

> >  			reg = <0x00900000 0x4000>;
> >  			#clock-cells = <1>;
> >  			#reset-cells = <1>;
> > +			#power-domain-cells = <1>;
> > +
> > +			tsens: thermal-sensor@900000 {
> > +				compatible = "qcom,ipq8064-tsens";
> > +
> > +				nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>;
> > +				nvmem-cell-names = "calib", "calib_backup";
> > +				interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
> > +				interrupt-names = "uplow";
> > +
> > +				#qcom,sensors = <11>;
> > +				#thermal-sensor-cells = <1>;
> > +			};
> 
> We have sensor under gcc node..?

Weirdly, yes, that seems to be where it lives for the 8064.

J.

-- 
I'm dangerous when I know what I'm doing.