Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 13:05:06 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Meng.Li@windriver.com
Cc:     linux-kernel@vger.kernel.org, maz@kernel.org, arnd@arndb.de
Subject: Re: [PATCH] mfd: syscon: free the allocated name field of struct
 regmap_config
Message-ID: <20210519120506.GA2414669@dell>
References: <20210407052525.27592-1-Meng.Li@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210407052525.27592-1-Meng.Li@windriver.com>
Precedence: bulk

On Wed, 07 Apr 2021, Meng.Li@windriver.com wrote:

> From: Limeng <Meng.Li@windriver.com>
> 
> The commit 529a1101212a("mfd: syscon: Don't free allocated name
> for regmap_config") doesn't free the allocated name field of struct
> regmap_config, but introduce a memory leak. There is another
> commit 94cc89eb8fa5("regmap: debugfs: Fix handling of name string
> for debugfs init delays") fixing this debugfs init issue from root
> cause. With this fixing, the name field in struct regmap_debugfs_node
> is removed. When initialize debugfs for syscon driver, the name
> field of struct regmap_config is not used anymore. So, the allocated
> name field of struct regmap_config is need to be freed directly after
> regmap initialization to avoid memory leak.
> 
> Fixes: 529a1101212a("mfd: syscon: Don't free allocated name for regmap_config")
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  drivers/mfd/syscon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog