Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <339ffb6f02457f7a293f19dbfed2aaf724f5c3d9.camel@redhat.com>
Subject: Re: [PATCH] usb: typec: ucsi: Clear pending after acking connector
 change
From:   Benjamin Berg <bberg@redhat.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 19 May 2021 13:50:31 +0200
In-Reply-To: <YKT3oEt/9fX8k8mw@kuha.fi.intel.com>
References: <20210516040953.622409-1-bjorn.andersson@linaro.org>
         <YKI/XT8qpZDjDuqs@kuha.fi.intel.com> <YKJeYzIgvL/soGgw@kuha.fi.intel.com>
         <cd62e9a6d317e106db5e5d6b5f36170524ed7ad9.camel@redhat.com>
         <YKPBPqZ6zHBsCnsO@kuha.fi.intel.com>
         <7c09a6bf2ee0a644863f1ec8b333c871cf83d5b8.camel@redhat.com>
         <YKT3oEt/9fX8k8mw@kuha.fi.intel.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-XcjbHHWXgMLPTtE0u8WR"
User-Agent: Evolution 3.40.0 (3.40.0-1.fc34) 
MIME-Version: 1.0
Precedence: bulk


--=-XcjbHHWXgMLPTtE0u8WR
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2021-05-19 at 14:33 +0300, Heikki Krogerus wrote:
> On Tue, May 18, 2021 at 08:04:14PM +0200, Benjamin Berg wrote:
> > On Tue, 2021-05-18 at 16:29 +0300, Heikki Krogerus wrote:
> > > On Mon, May 17, 2021 at 02:57:28PM +0200, Benjamin Berg wrote:
> > > >=20
> > > > [SNIP]
> > > > Unfortunately, I don't feel it'll work. The problem that I was
> > > > seeing
> > > > looked like a race condition in the PPM itself, where the
> > > > window is
> > > > the
> > > > time between the UCSI_GET_CONNECTOR_STATUS command and the
> > > > subsequent
> > > > ACK.
> > > > For such a firmware level bug in the PPM, we need a way to
> > > > detect
> > > > the
> > > > race condition when it happens (or get a fix for the firmware).
> > >=20
> > > OK. Let me know does the patch bring the issue back for you.
> >=20
> > So, I just tried the patch, and I can occasionally reproduce the
> > issue
> > where "online" for the ucsi power adapter is stuck at "1" after
> > unplugging with the patch applied.
>=20
> Thanks for testing it.
>=20
> I'm still not sure that the PPM is the culprit here. I have a feeling
> that the problem you are seeing is caused by the workaround (bad
> workaround) that we have for the issue where the EC firmware does not
> return with the BUSY bit set in the CCI when it should in many cases.
> The UCSI ACPI driver has one minute timeout value for command
> completion because of that, which is way too long. So if the EC
> firmware decides to take its time before acknowledging command, the
> driver is stuck, and we start loosing the events...

Hmm, interesting, yes. If the PPM is sending a second change event
before or after we ACK'ed the first one, and we loose this event, then
that would absolutely explain the issue I am seeing.

In my case, I was able to considerably increase the probability of the
bug by inserting a sleep just before acknowledging the connector
change. Not sure whether this is meaningful, but maybe that tells us
something about who is at fault here.

Benjamin

> Well, I guess
> technically the PPM would be the culprit in the end in any case, but
> I'm just not sure that there is any race like you suspected.
>=20
> But this is off topic. I'll send you an RFC proposal what I think we
> could do about that.
>=20
>=20
> thanks,
>=20


--=-XcjbHHWXgMLPTtE0u8WR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEED2NO4vMS33W8E4AFq6ZWhpmFY3AFAmCk+4cACgkQq6ZWhpmF
Y3D0sg/8CDF7hWwvLKZ75qOTY852GUjhJ462jiTVILJmXfADbvqYGoItnNe92qQZ
GDROv9dctE15hIDuC0pymi26iVbIBOD+oQ58oZrmTdZz0E8sGcW+fQ1x0XBruz0u
MijLlslZMf0+KlFQEq8p44DsxyuUaKMIR5VSebHy3RwpVLhXZoPYVCQT3odKPtcQ
6TSsFQXxwndOpTemhYOHKiKAuyao9LQ2Bifw7kESiCs94hDnJs7HP5IONGF8uTod
NvZxfxbjE7rNMQVqjAaYL08YIpaldGwwV8mU81l/N42v0U49iwJVyoGXXTR8SEnk
gRvLTeFWOfKxu6mV/dR75QcLQX7r73CGlBvAesb33A3QkslXxoRfvmXwLakufXqz
Zrbgzvm3ZiXTVB+22cgsY0dOFMPu3XxNmO7O2PfgsoaYSHPenIXTyS6nptfO/rQZ
O+ZWUmSgn0cmxcF7GILanJcS9vjqPdBFHprKQhaP934/YWmtyhLw5fds/0frGCjy
0eUawptVIsb+kmp0y7yJCFyCTb6iG9v5TjHtjnlBMOFmTqq5FhIl2TpyIKLlllT4
Fibqvjyykrz4xNFD0QM/Vy9UsZjwk4CaTdHegyZ/qlmHX+zvjiyGMoAo7b99+D3o
mzo1/wJx1XHJxUWS7lcEaSQCnjP6mWkALfFa7Vl8VtICf/pAFWg=
=l9/L
-----END PGP SIGNATURE-----

--=-XcjbHHWXgMLPTtE0u8WR--