Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 14:16:26 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Axel Lin <axel.lin@ingics.com>
Cc:     Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Check ramp_delay_table for
 regulator_set_ramp_delay_regmap
Message-ID: <20210519131626.GE4224@sirena.org.uk>
References: <20210519075024.1644990-1-axel.lin@ingics.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cYtjc4pxslFTELvY"
Content-Disposition: inline
In-Reply-To: <20210519075024.1644990-1-axel.lin@ingics.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--cYtjc4pxslFTELvY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 19, 2021 at 03:50:24PM +0800, Axel Lin wrote:

> +	if (!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table) {
> +		WARN_ON(!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table);

You can write "if (WARN_ON(..." there and it'll DTRT, though I'm never
sure it's great for readability.

--cYtjc4pxslFTELvY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmClD6oACgkQJNaLcl1U
h9C0bgf9Gjdn+dx9h/0a5itgBfbXwSWxqmKIBJz29U8zhmWt/sUtM21Rat05VG/u
r12bcVn/IIsBZRKL6iyDRopHUQIFh5jfS04TL1nfJIhd78il7bWziIU7YZ5jykKx
95zI9L7EXEIB8zXvPLNCXGNgpq0STPpmYSvvrsX3V5zYTmbCRWMMIRy9XEwWRKxC
hj6uWpyaRAxmOdtazvgP2vqknFOHjulbaNZVnS+ubDyRk+JzQSRU45Pf1e0l89n/
0wYVd4hxRg/QFOSpzq1hDDWPxpEhqu12F8f3uWQEVcJoZ57lpE8vVEtoChRILsto
cGDWixK2xQU3NDvehZ1z4fz7iLi+rQ==
=Aswp
-----END PGP SIGNATURE-----

--cYtjc4pxslFTELvY--