Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 16:20:44 +0200
Message-ID: <s5hfsyiiz43.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Colin King <colin.king@canonical.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        David Henningsson <coding@diwic.se>,
        alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ALSA: rawmidi: fix incorrect array bounds check on clock_names
In-Reply-To: <20210519105424.55221-1-colin.king@canonical.com>
References: <20210519105424.55221-1-colin.king@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 19 May 2021 12:54:24 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The array bounds check on clock_names is currently checking the size
> of the entire array rather than the number of elements in the array
> leading to a potential array bounds read error. Fix this by using
> the ARRAY_SIZE macro instead of sizeof.
> 
> Addresses-Coverity: ("Out-of-bounds read")
> Fixes: 08fdced60ca0 ("ALSA: rawmidi: Add framing mode")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied.


Takashi