Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Pu Lehui <pulehui@huawei.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "kpsingh@kernel.org" <kpsingh@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Make some symbols static
Thread-Topic: [PATCH bpf-next] bpf: Make some symbols static
Thread-Index: AQHXTKHfLfKX5VY/BkGohBXM265fJarrC12A
Date:   Wed, 19 May 2021 17:13:42 +0000
Message-ID: <10D9E2CC-1EF1-4F67-A5FC-735D1A1F1E40@fb.com>
References: <20210519064116.240536-1-pulehui@huawei.com>
In-Reply-To: <20210519064116.240536-1-pulehui@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F743EFACE5294847AF31F59C624E7C65@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 94ba53ed-bcc2-4432-8700-08d91ae973eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2021 17:13:42.1834
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fD1HSMT+wXKT2zRUzBEZZBz12zUrWGQTzAhD/mJNFP2edulwwUyhW0QtI0WxQAcsyZ9/Z4Srhb009T0SGUdLYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR15MB3665
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: 68TC0cep8kGNCNBY-mqoJAqsQOiOgFSO
X-Proofpoint-ORIG-GUID: 68TC0cep8kGNCNBY-mqoJAqsQOiOgFSO
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-05-19_09:2021-05-19,2021-05-19 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 suspectscore=0 bulkscore=0 spamscore=0 clxscore=1011 priorityscore=1501
 lowpriorityscore=0 phishscore=0 impostorscore=0 adultscore=0 mlxscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105190103
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 18, 2021, at 11:41 PM, Pu Lehui <pulehui@huawei.com> wrote:
>=20
> The sparse tool complains as follows:
>=20
> kernel/bpf/syscall.c:4567:29: warning:
> symbol 'bpf_sys_bpf_proto' was not declared. Should it be static?
> kernel/bpf/syscall.c:4592:29: warning:
> symbol 'bpf_sys_close_proto' was not declared. Should it be static?
>=20
> This symbol is not used outside of syscall.c, so marks it static.
>=20
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Acked-by: Song Liu <songliubraving@fb.com>

> ---
> kernel/bpf/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index 2361d97e2c67..73d15bc62d8c 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -4564,7 +4564,7 @@ BPF_CALL_3(bpf_sys_bpf, int, cmd, void *, attr, u32=
, attr_size)
> 	return __sys_bpf(cmd, KERNEL_BPFPTR(attr), attr_size);
> }
>=20
> -const struct bpf_func_proto bpf_sys_bpf_proto =3D {
> +static const struct bpf_func_proto bpf_sys_bpf_proto =3D {
> 	.func		=3D bpf_sys_bpf,
> 	.gpl_only	=3D false,
> 	.ret_type	=3D RET_INTEGER,
> @@ -4589,7 +4589,7 @@ BPF_CALL_1(bpf_sys_close, u32, fd)
> 	return close_fd(fd);
> }
>=20
> -const struct bpf_func_proto bpf_sys_close_proto =3D {
> +static const struct bpf_func_proto bpf_sys_close_proto =3D {
> 	.func		=3D bpf_sys_close,
> 	.gpl_only	=3D false,
> 	.ret_type	=3D RET_INTEGER,
> --=20
> 2.17.1
>=20