Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jeff Moyer <jmoyer@redhat.com>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     bcrl@kvack.org, akpm@linux-foundation.org, linux-aio@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aio: add missing dcache flush
References: <YJRLAPfYuNaCWq6T@localhost.localdomain>
Date:   Wed, 19 May 2021 14:40:22 -0400
In-Reply-To: <YJRLAPfYuNaCWq6T@localhost.localdomain> (Alexey Dobriyan's
        message of "Thu, 6 May 2021 23:01:04 +0300")
Message-ID: <x495yze36uh.fsf@segfault.boston.devel.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Alexey Dobriyan <adobriyan@gmail.com> writes:

> Ring page is mapped by kernel and updated so dcache must be flushed.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> 	Not tested but the usage looks fishy.
>
>  fs/aio.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -653,6 +653,7 @@ static int ioctx_add_table(struct kioctx *ctx, struct mm_struct *mm)
>  					ring = kmap_atomic(ctx->ring_pages[0]);
>  					ring->id = ctx->id;
>  					kunmap_atomic(ring);
> +					flush_dcache_page(ctx->ring_pages[0]);
>  					return 0;
>  				}
>  
>

Sorry for the late review.

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>