Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 20:27:39 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Daniel Bristot de Oliveira <bristot@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
        Kate Carcia <kcarcia@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Will Deacon <will@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Gabriele Paoloni <gabriele.paoloni@intel.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>, linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH 04/16] rv/include: Add deterministic automata monitor
 definition via C macros
Message-ID: <20210519182739.GG21560@worktop.programming.kicks-ass.net>
References: <cover.1621414942.git.bristot@redhat.com>
 <1e67370a0808714325b434edfe8f84178867af47.1621414942.git.bristot@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1e67370a0808714325b434edfe8f84178867af47.1621414942.git.bristot@redhat.com>
Precedence: bulk

On Wed, May 19, 2021 at 01:36:25PM +0200, Daniel Bristot de Oliveira wrote:

> +struct da_monitor {
> +	char curr_state;
> +	bool monitoring;
> +	void *model;
> +};
> +
> +#define MAX_PID		 1024000

> +/*
> + * Functions to define, init and get a per-task monitor.
> + *
> + * XXX: Make it dynamic? make it part of the task structure?

Yes !

I'd start with maybe adding a list_head to da_monitor and embedding a
single copy into task_struct and link from there. Yes lists suck, but
how many monitors do you realistically expect to run concurrently?

> + */
> +#define DECLARE_DA_MON_INIT_PER_TASK(name, type)				\
> +										\
> +struct da_monitor da_mon_##name[MAX_PID];					\

That's ~16M of memory, which seems somewhat silly.

> +										\
> +static inline struct da_monitor *da_get_monitor_##name(pid_t pid)		\
> +{										\
> +	return &da_mon_##name[pid];						\
> +}										\
> +										\
> +void da_monitor_reset_all_##name(void)						\
> +{										\
> +	struct da_monitor *mon = da_mon_##name;					\
> +	int i;									\
> +	for (i = 0; i < MAX_PID; i++)						\
> +		da_monitor_reset_##name(&mon[i]);				\
> +}										\
> +										\
> +static void da_monitor_init_##name(void)					\
> +{										\
> +	struct da_monitor *mon = da_mon_##name;					\
> +	int i;									\
> +										\
> +	for (i = 0; i < MAX_PID; i++) {						\
> +		mon[i].curr_state = model_get_init_state_##name();		\
> +		mon[i].monitoring = 0;						\
> +		mon[i].model = model_get_model_##name();			\
> +	}									\
> +}										\