Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] staging: greybus: spi: add blank line after variable
 declaration
To:     Philippe Dixon <philippesdixon@gmail.com>, vireshk@kernel.org
Cc:     rmfrfs@gmail.com, johan@kernel.org, elder@kernel.org,
        gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20210519193938.GA7131@ubuntu>
From:   Alex Elder <elder@ieee.org>
Message-ID: <7694715e-41b9-08e2-68f5-0fd57223a3ab@ieee.org>
Date:   Wed, 19 May 2021 14:53:09 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210519193938.GA7131@ubuntu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/19/21 2:39 PM, Philippe Dixon wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Philippe Dixon <philippesdixon@gmail.com>

Looks good.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>   drivers/staging/greybus/spilib.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
> index 30655153df6a..ad0700a0bb81 100644
> --- a/drivers/staging/greybus/spilib.c
> +++ b/drivers/staging/greybus/spilib.c
> @@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
>   	xfer = spi->first_xfer;
>   	while (msg->state != GB_SPI_STATE_OP_DONE) {
>   		int xfer_delay;
> +
>   		if (xfer == spi->last_xfer)
>   			xfer_len = spi->last_xfer_size;
>   		else
>