Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 20:32:59 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Aaron Tomlin <atomlin@redhat.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz,
        mhocko@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_alloc: bail out on fatal signal during
 reclaim/compaction retry attempt
Message-ID: <YKVn69o1UizH0kJD@casper.infradead.org>
References: <20210519192321.3247175-1-atomlin@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210519192321.3247175-1-atomlin@redhat.com>
Precedence: bulk

On Wed, May 19, 2021 at 08:23:21PM +0100, Aaron Tomlin wrote:
> +++ b/mm/page_alloc.c
> @@ -4252,6 +4252,9 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags,
>  	if (!order)
>  		return false;
>  
> +	if (fatal_signal_pending(current))
> +		goto out;

I think 'goto out' will be confusing.  It'll output a tracepoint, which
isn't going to record that a fatal signal is pending, so it'll cause
some head scratching for someone looking through the traces.  I
think we should just return false here and skip the tracepoint.

But I'd defer to someone like Vlastimil or Michal who know this code far
better than I do.