Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] Staging: greybus: fix open parenthesis error in
 gbphy.c
To:     "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>, johan@kernel.org,
        elder@kernel.org, gregkh@linuxfoundation.org
Cc:     greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20210519181938.30813-1-asha.16@itfac.mrt.ac.lk>
From:   Alex Elder <elder@ieee.org>
Message-ID: <4af943f6-9baa-72a6-12b5-6b35179a7019@ieee.org>
Date:   Wed, 19 May 2021 15:06:42 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210519181938.30813-1-asha.16@itfac.mrt.ac.lk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/19/21 1:19 PM, F.A.Sulaiman wrote:
> This patch fix "Alignment should match open parenthesis" checkpatch error.
> 
> Signed-off-by: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>

I have mixed feelings about this one.  This alignment rule
is fine, but I personally don't think it improves things.

Aside from that, there are a few more places in the Greybus
code that lead to exactly this warning.  So I guess, if we're
going to have the code follow this alignment rule, why not
just fix all spots at once (i.e., in a patch series)?

Anyway, I'll offer this, but perhaps others can provide
their opinion.

Acked-by: Alex Elder <elder@linaro.org>

> ---
>   drivers/staging/greybus/gbphy.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 9fc5c47be9bd..13d319860da5 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -27,7 +27,7 @@ struct gbphy_host {
>   static DEFINE_IDA(gbphy_id);
>   
>   static ssize_t protocol_id_show(struct device *dev,
> -				 struct device_attribute *attr, char *buf)
> +				struct device_attribute *attr, char *buf)
>   {
>   	struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
>   
> @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
>   EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);
>   
>   static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
> -				struct greybus_descriptor_cport *cport_desc)
> +						struct greybus_descriptor_cport *cport_desc)
>   {
>   	struct gbphy_device *gbphy_dev;
>   	int retval;
>