Received: by 2002:a05:6520:4211:b029:f4:110d:56bc with SMTP id o17csp1586095lkv; Wed, 19 May 2021 13:25:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZn1K6aG/sEUhq19C91/EUHRFt6dwAzDpAwe4Jy6HpevUkts0+msLBEyxCA9bBz1xGKxTq X-Received: by 2002:a92:c541:: with SMTP id a1mr986132ilj.99.1621455814030; Wed, 19 May 2021 13:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621455814; cv=none; d=google.com; s=arc-20160816; b=BOUwl3VyIhMHRjq0O2Lig0dcqNTaj2wU5x0OL8+iFEtzhCVF2Q+x9AlUAZYwnPT/Bl nlkmRiRDP78hKDlhzHwcfty/SaW3mlCfTJ8wwnEI075ga5oSh4bDkPKxoIEt1X45Saqx h8u9H9Ri9Suq5kdizI+BSj3PnPDrMA0iiDZDc1YdodF4xK1zWVcdAgkH5fzZDRtNmwuB +tMdPJ04bJvZhNDuSnJMEAyTAt5Tqj5/9SjZwjbYgXcY2QrtHIrVg3yzdO/wYn9vbCf5 l8PwhITftKdV5NYf04ZH+7hBPToFlhTeK5a4pFPNxYsY0Svejjj+HQ8ssdrhd3SkYJsb gJSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :dkim-signature; bh=o4jBnun2LSkXDmFiIlCKYTFr+oT+1PQC4hYSvDF/i3w=; b=FTfOKWyajw/nbo/NirTmJAZbr04KJdD3LCoJV9SYLipyhN7DK4shcfT145HWw2kDr4 xsWVnIuhEAfNQCzdmqdvZKDNK5Pise2rHRX+vZj6dyxiom4/RBSc5gQbh3q7KEpSRY6v 2MjF0I4L4dmi/Ypibzf2kfhqTeHgWGDfjnk0aWfAb1UXKl4mPSW/zMsBZ7rmnJsO+viq GK4CnB0yUBX0u3e2NE8ms/QLdEr7ULuGqlaDucWYvr9oAdrOwXbR2zeDa6EF5cg3xcYX x3+dVJlwQckSfLSN4zkqkSNIFG7uBvVCinVaiWkHweETdf134iQE5bbHgWLkqFM2BfUC rC2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=edWurywZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si714622ilq.40.2021.05.19.13.23.20; Wed, 19 May 2021 13:23:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=edWurywZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232178AbhESTnh (ORCPT + 99 others); Wed, 19 May 2021 15:43:37 -0400 Received: from ssl.serverraum.org ([176.9.125.105]:44087 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhESTng (ORCPT ); Wed, 19 May 2021 15:43:36 -0400 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id BD39D22178; Wed, 19 May 2021 21:42:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1621453332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o4jBnun2LSkXDmFiIlCKYTFr+oT+1PQC4hYSvDF/i3w=; b=edWurywZjdeWJTnNg9V7vpsyUR7RzqcRH28dfvryzJ20dy/kY2UELkS+jhTiU+gGn8TDOl fbD5SU21m3zjoeNh7/nY7sI+TQ1wHT1jPJNzYoAGOnjGYLlI03Rlq1WOygzHVFIisUirdf VYdud+aU8VdMHf3ousvOf8uZvS0UBjg= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 19 May 2021 21:42:11 +0200 From: Michael Walle To: Robert Marko Cc: Lee Jones , robh+dt@kernel.org, Linus Walleij , bgolaszewski@baylibre.com, jdelvare@suse.com, Guenter Roeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, Luka Perkov , jmp@epiphyte.org, Paul Menzel , Donald Buczek Subject: Re: [PATCH 1/6] mfd: Add Delta TN48M CPLD driver In-Reply-To: References: <20210430123511.116057-1-robert.marko@sartura.hr> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <0f28cabf858154842819935000f32bc2@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 2021-05-19 13:53, schrieb Robert Marko: > On Thu, May 6, 2021 at 6:34 PM Michael Walle wrote: >> Am 2021-04-30 14:35, schrieb Robert Marko: >> > Delta TN48M switches have a Lattice CPLD that serves >> > multiple purposes including being a GPIO expander. >> > So lets add the MFD core driver for it. >> >> Did you have a look at mfd/simple-mfd-i2c.c? > > Yes, that was my first idea but we have a requirement to expose CPLD > information via debugfs as there are userspace applications using it. > And simple-mfd-i2c does not allow us to do so. Mh, last time Lee wasn't very fond of having a driver that just populates sub-drivers while doing almost nothing itself. See https://lore.kernel.org/lkml/20200605065709.GD3714@dell/ That being said, I'd also like to expose our CPLD version, but until now haven't found a good solution. -michael