Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 13:49:41 -0700
From:   Moritz Fischer <mdf@kernel.org>
To:     trix@redhat.com
Cc:     mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] fpga: generalize updating to partial and full
Message-ID: <YKV55XK1Py5YSXZp@epycbox.lan>
References: <20210519204256.1975957-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210519204256.1975957-1-trix@redhat.com>
Precedence: bulk

Tom,

On Wed, May 19, 2021 at 01:42:56PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> There is a need to update the whole card.
> The user area, the shell and even the card firmware.
> This needs to be handled differently than the
> existing partial updating in the fpga manager.
> 
> Move the write_* ops out of fpga_manager_ops and
> into a new fpga_manager_update_ops struct.  Add
> two update_ops back to fpga_manager_ops,
> partial_update for the exiting functionality and
> full_update for the new functionity.

Partial and Full are somewhat loaded terms with FPGAs -- think partial
reconfiguration vs full reconfiguration.

How about 'persistent' and 'volatile' or something along those lines
instead?

- Moritz